Date: Tue, 19 May 1998 06:54:52 +1000 From: Bruce Evans <bde@zeta.org.au> To: guido@FreeBSD.ORG, jhay@mikom.csir.co.za Cc: cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet tcp_input.c Message-ID: <199805182054.GAA30065@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> guido 1998/05/18 10:07:59 PDT >> >> Modified files: >> sys/netinet tcp_input.c >> Log: >> Add some parenthesis for clarity and fix a bug >> Pointed out by: Garrett Wollmand > ^ >Shouldn't you also add this to rc.network so that it can start >automatically on new machines? :-) Then you should also add the bd :-). It deletes parentheses for clarity. Its review of this patch: "2 extra layers of parentheses is 2 more layers than I would use and 1 more layer than KNF. This change has no affect on the object code. Where is the bug fix?". [The change was from `(foo & BAR && ...' to (((foo & BAR) != 0) && ...'.] Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199805182054.GAA30065>