Date: Fri, 23 Dec 2011 20:50:07 -0500 From: Alexander Kabaev <kabaev@gmail.com> To: Erik Cederstrand <erik@cederstrand.dk> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: GCC debug flags cleanup Message-ID: <20111223205007.16eb27c5@kan.dyndns.org> In-Reply-To: <DED3F527-DD1F-4996-81EF-E3F30ED3E606@cederstrand.dk> References: <DED3F527-DD1F-4996-81EF-E3F30ED3E606@cederstrand.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/ztyrywUZZxS271OCdvd7=Qn Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 22 Dec 2011 12:52:45 +0100 Erik Cederstrand <erik@cederstrand.dk> wrote: > Hi, >=20 > I've created a patch that cleans up FreeBSD Makefiles that > unconditionally set the -g flag for GCC. The motivation for this is > that it should be possible to add or remove this flag globally via > e.g. CFLAGS (it's part of my quest to produce deterministic builds). >=20 > I'm not very familiar with GCC or the build infrastructure, so I'd be > grateful if someone would review it and possibly commit. >=20 > http://dev.affect-it.dk/gcc_debug_flags.diff >=20 > Thanks, > Erik_______________________________________________ gnu/usr.bin/cc/cc_tools/Makefile just builds tools that are used for building gcc itself and are non installed anywhere outside of $OBJDIR. I doubt disabling -g there buys you much, but having it there is also of questionable value. Verdict: could not care less either way. All of the gcc/contrib changes are useless - we are not using any of stock Makefiles. sys/amd64/conf/GENERIC - please understang _why_ it is there before you remove it. When you do, you will probably will drop the idea. -- Alexander Kabaev --Sig_/ztyrywUZZxS271OCdvd7=Qn Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iD8DBQFO9S/UQ6z1jMm+XZYRAlx7AKC7vT3F4MUp67Zvnr/n5qEKZMEX5ACgqnNK csnj4zYsHkUWfMshk5qkH7Y= =VVOB -----END PGP SIGNATURE----- --Sig_/ztyrywUZZxS271OCdvd7=Qn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111223205007.16eb27c5>