Date: Wed, 1 Oct 2025 21:01:57 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: Renato Botelho <garga@freebsd.org> Cc: Mateusz Guzik <mjg@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 08f06aa1b4fb - main - vfs: retire the VCALL macro Message-ID: <CAGudoHHPO6anvVqAncZBhkuk1nuPBgxaEuW=%2B4Edq1QmuQ8Lag@mail.gmail.com> In-Reply-To: <85c486e1-6fde-4f4a-b4ce-bfbec7bb693f@FreeBSD.org> References: <202509270401.58R41A7b014829__21824.1523530864$1758945716$gmane$org@gitrepo.freebsd.org> <85c486e1-6fde-4f4a-b4ce-bfbec7bb693f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 1, 2025 at 8:35=E2=80=AFPM Renato Botelho <garga@freebsd.org> w= rote: > > On 27/09/25 01:01, Mateusz Guzik wrote: > > The branch main has been updated by mjg: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D08f06aa1b4fb6db0d8beb3e1= c328b1c1adbec13a > > > > commit 08f06aa1b4fb6db0d8beb3e1c328b1c1adbec13a > > Author: Mateusz Guzik <mjg@FreeBSD.org> > > AuthorDate: 2025-09-27 02:01:32 +0000 > > Commit: Mateusz Guzik <mjg@FreeBSD.org> > > CommitDate: 2025-09-27 04:00:59 +0000 > > > > vfs: retire the VCALL macro > > > > There is precisely one place using it and even that should probabl= y go > > away. > > --- > > sys/fs/nullfs/null_vnops.c | 2 +- > > sys/sys/vnode.h | 5 ----- > > 2 files changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/sys/fs/nullfs/null_vnops.c b/sys/fs/nullfs/null_vnops.c > > index 74c1a8f3acb6..ba29b0485326 100644 > > --- a/sys/fs/nullfs/null_vnops.c > > +++ b/sys/fs/nullfs/null_vnops.c > > @@ -306,7 +306,7 @@ null_bypass(struct vop_generic_args *ap) > > * with the modified argument structure. > > */ > > if (vps_p[0] !=3D NULL && *vps_p[0] !=3D NULL) { > > - error =3D VCALL(ap); > > + error =3D ap->a_desc->vdesc_call(ap); > > } else { > > printf("null_bypass: no map for %s\n", descp->vdesc_name)= ; > > error =3D EINVAL; > > diff --git a/sys/sys/vnode.h b/sys/sys/vnode.h > > index 6ef9bbec9446..fcfb8716fc52 100644 > > --- a/sys/sys/vnode.h > > +++ b/sys/sys/vnode.h > > @@ -594,11 +594,6 @@ void assert_vop_unlocked(struct vnode *vp, con= st char *str); > > > > #endif /* INVARIANTS */ > > > > -/* > > - * This call works for vnodes in the kernel. > > - */ > > -#define VCALL(c) ((c)->a_desc->vdesc_call(c)) > > - > > #define DOINGASYNC(vp) \ > > (((vp)->v_mount->mnt_kern_flag & MNTK_ASYNC) !=3D 0 && \ > > ((curthread->td_pflags & TDP_SYNCIO) =3D=3D 0)) > > > > > > FYI, this commit along with retirement of NULLVP and VREF broke > open-vm-kmod build on current. I wonder if there are move ports that > could be affected. > I could bump __freebsd_version for it, but what you can do is simply not use the old stuff on any supported branch.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHHPO6anvVqAncZBhkuk1nuPBgxaEuW=%2B4Edq1QmuQ8Lag>