Date: Thu, 2 Nov 2006 12:22:46 +0100 From: Hans Petter Selasky <hselasky@c2i.net> To: John Baldwin <jhb@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org>, Scott Long <scottl@freebsd.org> Subject: Re: PERFORCE change 108878 for review Message-ID: <200611021222.48108.hselasky@c2i.net> In-Reply-To: <200611011047.07627.jhb@freebsd.org> References: <200611010112.kA11C1Jt066210@repoman.freebsd.org> <200611011047.07627.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 01 November 2006 16:47, John Baldwin wrote: > On Tuesday 31 October 2006 20:12, Scott Long wrote: > > http://perforce.freebsd.org/chv.cgi?CH=108878 > > > > Change 108878 by scottl@scottl-x64 on 2006/11/01 01:11:30 > > > > For some wonderful reason, you cannot pass &Giant to msleep. Work > > around that in a crude fashion. Also add some more assertions. > > Ah, yes, that would be most unhappy. I guess mostly the idea is that Giant > should be rather implicit and explicitly using Giant for an object lock is > discouraged. I'm not sure that is what you are doing though. I think > maybe you are borrowing Giant that's already held? I use this patch: /* preliminary fix for a bug in msleep on FreeBSD, * which cannot sleep with Giant: */ #define msleep(i,m,p,w,t) msleep(i,(((m) == &Giant) ? NULL : (m)),p,w,t) Really this issue should be fixed. It happens just because GIANT_DROP is done too early in "msleep()". --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611021222.48108.hselasky>