Date: Sun, 9 Jan 2005 04:00:59 -0500 From: Tom Rhodes <trhodes@FreeBSD.org> To: Colin Percival <colin.percival@wadham.ox.ac.uk> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ping6 Makefile ping6.c Message-ID: <20050109040059.6e14a902@mobile.pittgoth.com> In-Reply-To: <41E0D155.9020704@wadham.ox.ac.uk> References: <200501082256.j08Mu9XJ015280@repoman.freebsd.org> <41E0D155.9020704@wadham.ox.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 08 Jan 2005 22:38:13 -0800 Colin Percival <colin.percival@wadham.ox.ac.uk> wrote: > Tom Rhodes wrote: > > Modified files: > > sbin/ping6 Makefile ping6.c > > Log: > > Use static const char and bump WARNS. > > Judging by the latest tinderbox build, it looks like you > need to replace "size_t" with "socklen_t" at line 1772 of > ping6.c before setting WARNS=6. But I only bumped it to two. But with that change, I get this on my p4: %make WARNS=6 Warning: Object directory not changed from original /usr/home/trhodes/work/curr nt/src/sbin/ping6 cc -O -pipe -march=pentium4 -DINET6 -DIPSEC -DKAME_SCOPEID -DUSE_RFC2292BIS -D AVE_POLL_H -DHAVE_ARC4RANDOM -Wsystem-headers -Werror -Wall -Wno-format-y2k -W Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qu l -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wchar-subscripts -Winline -Wn sted-externs -Wredundant-decls -c ping6.c ping6.c: In function `main': ping6.c:398: warning: comparison between signed and unsigned ping6.c:694: warning: comparison between signed and unsigned ping6.c:726: warning: comparison between signed and unsigned ping6.c: In function `dnsdecode': ping6.c:1432: warning: comparison between signed and unsigned ping6.c: In function `pr_pack': ping6.c:1490: warning: comparison between signed and unsigned ping6.c: At top level: ping6.c:2172: warning: unused parameter 'notused' ping6.c: In function `pr_retip': ping6.c:2525: warning: comparison between signed and unsigned ping6.c: In function `fill': ping6.c:2619: warning: comparison between signed and unsigned ping6.c: At top level: ping6.c:2635: warning: unused parameter 'so' *** Error code 1 Stop in /usr/home/trhodes/work/current/src/sbin/ping6. Looks like just that change doesn't make it WARNS=6 clean. :) -- Tom Rhodes
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050109040059.6e14a902>