Date: Sun, 15 Sep 2013 07:48:42 +0000 (UTC) From: Jean-Sebastien Pedron <dumbbell@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r255587 - head/sys/dev/drm2/radeon Message-ID: <201309150748.r8F7mg6H019063@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dumbbell Date: Sun Sep 15 07:48:42 2013 New Revision: 255587 URL: http://svnweb.freebsd.org/changeset/base/255587 Log: drm/radeon: Add missing "return false" after unmapping invalid BIOS Without that, we would try to copy the unmapped BIOS. Submitted by: Christoph Mallon <christoph.mallon@gmx.de> Approved by: re (blanket) Modified: head/sys/dev/drm2/radeon/radeon_bios.c Modified: head/sys/dev/drm2/radeon/radeon_bios.c ============================================================================== --- head/sys/dev/drm2/radeon/radeon_bios.c Sun Sep 15 01:44:07 2013 (r255586) +++ head/sys/dev/drm2/radeon/radeon_bios.c Sun Sep 15 07:48:42 2013 (r255587) @@ -123,6 +123,7 @@ static bool radeon_read_bios(struct rade __func__, bios[0], bios[1]); } vga_pci_unmap_bios(vga_dev, bios); + return false; } rdev->bios = malloc(size, DRM_MEM_DRIVER, M_WAITOK); memcpy(rdev->bios, bios, size);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201309150748.r8F7mg6H019063>