Date: Fri, 8 Dec 2017 13:57:13 -0500 From: Ryan Stone <rysto32@gmail.com> To: Stephen Hurd <shurd@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r326702 - head/sys/net Message-ID: <CAFMmRNz1HFyxxoj4Mapdoa9puVjm21hGjOiKGB-0V3V2WpWOsw@mail.gmail.com> In-Reply-To: <201712081843.vB8IhVdA064251@repo.freebsd.org> References: <201712081843.vB8IhVdA064251@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 8, 2017 at 1:43 PM, Stephen Hurd <shurd@freebsd.org> wrote: > Author: shurd > Date: Fri Dec 8 18:43:31 2017 > New Revision: 326702 > URL: https://svnweb.freebsd.org/changeset/base/326702 > + if (!M_WRITABLE(*m_head)) { > + new_head = m_dup(*m_head, M_NOWAIT); > + if (new_head == NULL) { > + device_printf(dev, "cannot pad short frame, m_dup() failed"); > + return ENOMEM; Don't we leak *m_head here? As far as I can tell the caller doesn't deal with it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFMmRNz1HFyxxoj4Mapdoa9puVjm21hGjOiKGB-0V3V2WpWOsw>