Date: Sat, 21 Sep 2013 21:46:30 -0600 From: "Justin T. Gibbs" <gibbs@FreeBSD.org> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r255783 - head/sys/kern Message-ID: <0CCA0163-C649-4A61-B6E6-06096327461E@FreeBSD.org> In-Reply-To: <523E6538.5090301@freebsd.org> References: <201309220246.r8M2kEIN054172@svn.freebsd.org> <523E6538.5090301@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sep 21, 2013, at 9:34 PM, Nathan Whitehorn <nwhitehorn@freebsd.org> = wrote: > On 09/21/13 21:46, Justin T. Gibbs wrote: >> Author: gibbs >> Date: Sun Sep 22 02:46:13 2013 >> New Revision: 255783 >> URL: http://svnweb.freebsd.org/changeset/base/255783 >>=20 >> Log: >> Fix ia64 and mips kernel builds due to XENHVM=3D>GENERIC = integration in >> revision 255744. >> sys/kern/subr_smp.c: >> IPI_SUSPEND is only available on amd64 and i386. Protect >> new uses of this constant with #ifdefs to avoid impacting >> other platforms. >=20 > Would it make more sense just to add this to other platforms? It = needn't actually be sent, of course, and it would cut down on = platform-specific #ifdef in MI code, which is universally a good thing. > -Nathan Sure. But the build was broken and I opted to restore the status quo = rather than take the more time consuming path of trying to clean up all = of the other #ifdefs and then having to reverify builds on all supported = platforms. -- Justin=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0CCA0163-C649-4A61-B6E6-06096327461E>