Date: Thu, 8 Nov 2007 15:13:41 +0100 From: Olivier Houchard <mlfbsd@ci0.org> To: Rafal Jaworowski <raj@semihalf.com> Cc: freebsd-arm@freebsd.org Subject: Re: ARM9E missing l2cache_* entries Message-ID: <20071108141341.GA35343@ci0.org> In-Reply-To: <47330BC3.3050208@semihalf.com> References: <47330BC3.3050208@semihalf.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 08, 2007 at 02:14:43PM +0100, Rafal Jaworowski wrote: > Hi, > > It seems there are missing entries for the l2cache_* calls in current > armv5_ec_cpufuncs initialization: > > --- a/src/sys/arm/arm/cpufunc.c > +++ b/src/sys/arm/arm/cpufunc.c > @@ -332,6 +332,10 @@ struct cpu_functions armv5_ec_cpufuncs = > > armv5_ec_idcache_wbinv_all, /* idcache_wbinv_all */ > armv5_ec_idcache_wbinv_range, /* idcache_wbinv_range */ > + cpufunc_nullop, /* l2cache_wbinv_all */ > + (void *)cpufunc_nullop, /* l2cache_wbinv_range */ > + (void *)cpufunc_nullop, /* l2cache_inv_range */ > + (void *)cpufunc_nullop, /* l2cache_wb_range */ > > /* Other functions */ > > I committed it. Thanks ! > BTW: is really both CPU_ARM9 and CPU_ARM9E needed like we have in the > sys/arm/at91/std.at91? I'm a bit confused when looking at the cpufunc.c if > they are meant mutually exclusive or not? > > Rafal I'd guess yes. CPU_ARM9 is armv4, CPU_ARM9E is armv5. Regards, Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071108141341.GA35343>