Date: Wed, 21 Apr 2004 13:35:46 +0300 From: Maxim Sobolev <sobomax@portaone.com> To: Eivind Eklund <eivind@FreeBSD.ORG> Cc: cvs-ports@FreeBSD.ORG Subject: Re: files/patch-* pathname separators (was Re: cvs commit:ports/games Makefile ...) Message-ID: <40864E82.90904@portaone.com> In-Reply-To: <20040421094050.GA5052@FreeBSD.org> References: <200404181922.i3IJMkTf044706@repoman.freebsd.org> <20040419032304.GA61048@regency.nsu.ru> <20040419103101.GB26102@dragon.nuxi.com> <20040419110810.GA24385@regency.nsu.ru> <20040420200903.GA6174@dragon.nuxi.com> <20040421094050.GA5052@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I disagree. `::' is pretty harmless, I never had any problems due to it. And, yes, I use bash as my primary shell. -Maxim Eivind Eklund wrote: > On Tue, Apr 20, 2004 at 01:09:03PM -0700, David O'Brien wrote: > >>On Mon, Apr 19, 2004 at 06:08:10PM +0700, Alexey Dokuchaev wrote: >> >>>While particular choice for a separator is arguable, the general scheme >>>for patch-files is not, right? FWIW, that was my point, not `::' vs. >>>whatever. >>> >>>As a side note, I don't really see any problem with `::' or `-'. >> >>1. Bash escapes it so it actually becomes 4 characters. >> This should not be takeing lightly -- people bitched about '%' in >> patch names and they were all changed because its a magic charter for >> Perforce and Perforce users could be bothered to escape it. >> >>2. With the file name lenths of some of our patches (greater than 80 >> chars) two characters, when one will do, is annoying. > > > If nobody objects, I'll add the following patch to the porters handbook > to avoid profileration. > > Index: book.sgml > =================================================================== > RCS file: /home/dcvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v > retrieving revision 1.400 > diff -u -r1.400 book.sgml > --- book.sgml 16 Apr 2004 15:05:32 -0000 1.400 > +++ book.sgml 21 Apr 2004 09:38:25 -0000 > @@ -617,7 +617,10 @@ > first, <literal>ab</literal> second and so on. If you wish, > you can use names that indicate the pathnames of the files that > are patched, such as <filename>patch-Imakefile</filename> or > - <filename>patch-src-config.h</filename>. These files should > + <filename>patch-src-config.h</filename>. Due to issues with > + escaping in <command>bash</command> and <command>Perforce</command>, > + you should avoid using :: or % as separator in the patch filename. > + The files should > be stored in <makevar>PATCHDIR</makevar>, from where they will be > automatically applied. All patches should be relative to > <makevar>WRKSRC</makevar> (generally the directory your port's > > Eivind. > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40864E82.90904>