Date: Wed, 6 Jun 2018 11:26:16 -0700 From: Matthew Macy <mat.macy@gmail.com> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Kyle Evans <kevans@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334226 - head/lib/libpmcstat/pmu-events Message-ID: <CAPrugNopT4AKKahqBheuKig9uRp8=t9_-JeO6OVnHqRP8CDL8A@mail.gmail.com> In-Reply-To: <06289a72-2948-083f-d208-d9f36d88699e@FreeBSD.org> References: <201805252146.w4PLk7vL009258@repo.freebsd.org> <CACNAnaGg5jMBXk1nOnn6wMpbOcFBEJopPDr6QJBTA4660HNTkw@mail.gmail.com> <CACNAnaHEzcdJCxAE8Jec-kjzR%2B-APv9fYg50AiOvNn9SEgYaew@mail.gmail.com> <06289a72-2948-083f-d208-d9f36d88699e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
pmu events hasn't been in libpmcstat for a while On Wed, Jun 6, 2018 at 08:36 Bryan Drewery <bdrewery@freebsd.org> wrote: > On 6/5/18 12:32 AM, Kyle Evans wrote: > > On Mon, Jun 4, 2018 at 10:11 PM, Kyle Evans <kevans@freebsd.org> wrote: > >> On Fri, May 25, 2018 at 4:46 PM, Bryan Drewery <bdrewery@freebsd.org> > wrote: > >>> Author: bdrewery > >>> Date: Fri May 25 21:46:07 2018 > >>> New Revision: 334226 > >>> URL: https://svnweb.freebsd.org/changeset/base/334226 > >>> > >>> Log: > >>> Cleanup style > >>> > >>> Modified: > >>> head/lib/libpmcstat/pmu-events/Makefile > >>> > >>> Modified: head/lib/libpmcstat/pmu-events/Makefile > >>> > ============================================================================== > >>> --- head/lib/libpmcstat/pmu-events/Makefile Fri May 25 20:42:28 > 2018 (r334225) > >>> +++ head/lib/libpmcstat/pmu-events/Makefile Fri May 25 21:46:07 > 2018 (r334226) > >>> @@ -1,9 +1,10 @@ > >>> # $FreeBSD$ > >>> > >>> -PROG=jevents > >>> -SRCS=jevents.c jsmn.c json.c > >>> +PROG= jevents > >>> +SRCS= jevents.c jsmn.c json.c > >>> CFLAGS+= -Wno-cast-qual > >>> -.PATH: ${.CURDIR} > >>> -build-tools: jevents > >>> MAN= > >>> + > >>> +build-tools: jevents > >>> + > >>> .include <bsd.prog.mk> > >>> > >> > >> Hi Bryan, > >> > >> Something about this appears to be subtly wrong, but I can't quite pin > >> down what. I'm getting a failure in the lib32 build of libpmc: > >> > >> sh: ./pmu-events/jevents: not found > > I believe this was fixed by r334455. > > >> > >> My observations are that ${OBJDIR}/lib/libpmc/pmu-events/jevents > >> exists, as does ${SRCTOP}/lib/libpmc/pmu-events/jevents. > >> ${OBJDIR}/obj-lib32/lib/libpmc, OTOH, only contains _INCSINS.meta and > >> libpmc_events.c.meta. I'm guessing this is the problem- that > >> obj-lib32/... doesn't have the built jevents, but it's not obvious to > >> me why this is the case. > > > > Some additional context: > > > > SRCCONF is defined to a file that looks like this: > > > > WITH_BSD_GREP="YES" > > WITHOUT_BSD_GREP_FASTMATCH="YES" > > WITH_LOADER_LUA="YES" > > WITHOUT_FORTH="YES" > > > > _SRC_ENV_CONF and __MAKE_CONF are set to /dev/null; all three set in > > arguments to make(1). OBJDIR has been completely wiped before-hand. > > > > > -- > Regards, > Bryan Drewery > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPrugNopT4AKKahqBheuKig9uRp8=t9_-JeO6OVnHqRP8CDL8A>