Date: Sat, 8 Apr 2017 18:16:53 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Toomas Soome <tsoome@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316585 - in head/sys/boot: efi/boot1 efi/loader i386/common i386/loader i386/zfsboot zfs Message-ID: <20170408221653.qtqdvgcosguvugtt@mutt-hbsd> In-Reply-To: <201704061817.v36IHT8i088712@repo.freebsd.org> References: <201704061817.v36IHT8i088712@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--alzeaugu3mdk6utq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 06, 2017 at 06:17:29PM +0000, Toomas Soome wrote: > Author: tsoome > Date: Thu Apr 6 18:17:29 2017 > New Revision: 316585 > URL: https://svnweb.freebsd.org/changeset/base/316585 >=20 > Log: > loader: zfs reader should check all labels > =20 > The current zfs reader is only checking first label from each device, h= owever, > we do have 4 labels on device and we should check all 4 to be protected > against disk failures and incomplete label updates. > =20 > The difficulty is about the fact that 2 label copies are in front of the > pool data, and 2 are at the end, which means, we have to know the size = of > the pool data area. > =20 > Since we have now the mechanism from common/disk.c to use the partition > information, it does help us in this task; however, there are still some > corner cases. > =20 > Namely, if the pool is created without partition, directly on the disk, > and firmware will give us the wrong size for the disk, we only can check > the first two label copies. > =20 > Reviewed by: allanjude > Differential Revision: https://reviews.freebsd.org/D10203 This breaks bhyve userboot: # sh /usr/share/examples/bhyve/vmrun.sh -c 8 -m 16g -t tap4 -C /dev/nmdm-la= ptop-dev-03-A -d /dev/zvol/enctank/bhyve/laptop-dev-03/disk-01 laptop-dev-03 /boot/userboot.so: Undefined symbol "ldi_get_size" Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --alzeaugu3mdk6utq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAljpYVIACgkQaoRlj1JF bu5NqQ//eZMwx7fP1aU5I7LaJlxsqnh8bnKAxvEg9vDs2dHProTKRrdeDl8ozk1c /Ag661kWs+jGeIP84v8mSIGJedcQ2aphy3MwNg1o6BP2cWTcqW+Ij49ZJxKgMQHS AnZiB89wXmglwAlJlywVoK3weVhVjj4C9hq+FAJbPtYgsFWgjY2RQUs/M2fNzlEk 7Pnkg1bwvs0nhKuJseEGaXukOsbLxi66+qTep5wrS7iZnAIEkLUNKhj9T1UU4s4q lsesz9XCvmSY/frfxTJii70L5f2RCABfPj/MTbFBDX4veDCyW5OuNxeqCI8UtzNX efojtq/OIbYb5/AL8L6JffU/AYmOcoN+V3deErOU63saOkU1yxSqRnGzZuDoUflU z1f505Gb6l4nCsCdqQKo/S+QprsSsOK8C0ppSrKkrhbxHU3Bs3kcnOE2GrYceQwm n93ZRWcxNuqdOGDQH+DlVSMDzYvKOVikO96Ejj0XQrQNJK6stf1qPLuMm/F19E0r kT5a1UZCksx4O0uNX8jWIq7YL6LWd84pp4Twy0d20JmftT97Q7803LfeKf1z0fix eiLSne3oiltSS5qZI98u8N7/Cn9zTb2O0zpHjqPrebhOLPqcm6FjAceE3cSQ9MU4 xziofIgsC6EEARUxLG/8cxbGZZLGybTEpPuIQDzVCFlyhW2asAs= =f8/u -----END PGP SIGNATURE----- --alzeaugu3mdk6utq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170408221653.qtqdvgcosguvugtt>