Date: Tue, 06 Mar 2001 19:01:13 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Warner Losh <imp@harmony.village.org>, igorr@crosswinds.net, freebsd-current@FreeBSD.org Subject: Re: Correct size of kinfo_proc Message-ID: <3AA517D8.3AE21660@FreeBSD.org> References: <9377.983896057@critter>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp wrote: > In message <3AA50F01.6560C34A@FreeBSD.org>, Maxim Sobolev writes: > >Warner Losh wrote: > > > >> In message <20010228161009.B14235@linux.rainbow> Igor Robul writes: > >> : On Wed, Feb 28, 2001 at 03:00:48PM +0200, Maxim Sobolev wrote: > >> : > Hi Poul, > >> : > > >> : > In revision 1.31 of src/sys/sys/user.h you have added new ki_layout field to > >> : > kinfo_proc structure, but forgot to increase KINFO_PROC_SIZE from 644 to 648. > >> : > Please correct. > >> : Why don't use sizeof() insead of hardcoding numbers? > >> > >> Because KINFO_PROC_SIZE is part of the ABI. Changes to its size are > >> always wrong, in that they break the ABI. The checks are there to > >> tell us when the ABI has been broken. > > > >Well, we are now well informed about this, could we just fix sys/sys/user.h to match > >relity (credit goes to phk for broking it and ignoring my posts completely)? > > I've been kind of waiting for -current to actually work again. I hate > commiting to -current when it's bÆrked. > > Yes, fix it in <sys/user.h> for now, or better, do the right thing > with version numbers. Ah ok if so, I though that you just forgot about it. I think it would be wise for me to avoid hacking this part, especially considering that the only harm from this is warning message at bootup. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3AA517D8.3AE21660>