Date: Wed, 8 May 2019 09:39:46 -0600 From: Warner Losh <imp@bsdimp.com> To: Renato Botelho <garga@freebsd.org> Cc: Dmitry Chagin <dchagin@freebsd.org>, "Rodney W. Grimes" <rgrimes@freebsd.org>, svn-src-head <svn-src-head@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r347218 - head/sys/compat/linsysfs Message-ID: <CANCZdfrxdyw5WTS9ya4%2BH9ckM7sN1um=j0Jv8eXogxA6VSU=JA@mail.gmail.com> In-Reply-To: <57ea4a23-c78e-1871-e06b-baf4f78882fd@FreeBSD.org> References: <201905070508.x4758DW5015688@repo.freebsd.org> <201905070531.x475VuIY010069@gndrsh.dnsmgr.net> <CAC0jpUCgzef1ZAWqGXZTXv6_W19SzHtiKi0PcxiywX==vzHtdg@mail.gmail.com> <57ea4a23-c78e-1871-e06b-baf4f78882fd@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 7, 2019 at 4:45 AM Renato Botelho <garga@freebsd.org> wrote: > On 07/05/19 02:45, Dmitry Chagin wrote: > > =D0=B2=D1=82, 7 =D0=BC=D0=B0=D1=8F 2019 =D0=B3. =D0=B2 08:32, Rodney W.= Grimes <freebsd@gndrsh.dnsmgr.net>: > > > >>> Author: dchagin > >>> Date: Tue May 7 05:08:13 2019 > >>> New Revision: 347218 > >>> URL: https://svnweb.freebsd.org/changeset/base/347218 > >>> > >>> Log: > >>> Remove wrong copyright line. Discussed with Carlos Neira. > >>> > >>> Reported by: Rodney W. Grimes > >> normally just use a committers username, aka rgrimes or rgrimes@ > >> for these types of things. > >> > >> > > ah, I see only: Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> > > > > > > > >>> MFC after: 2 weeks > >>> Differential Revision: https://reviews.freebsd.org/D13656 > >> > >> Hang on, now you removed his copyright? > >> I see he said that was ok, but that was not the desired intent here. > >> It would of been fine to have the copyright read: > >> > >> * Copyright (c) 2006 IronPort Systems > >> * All rights reserved. > >> * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com > >> > >> As a heads up to other committers you should never insert your > >> copyright between another copyright and the "All rights reserved." tex= t, > >> if you wish to assert the all rights reserved you should duplicate > >> it like: > >> > >> * Copyright (c) 2006 IronPort Systems > >> * All rights reserved. > >> * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com > >> * All rights reserved. > >> > >> preferably on the line with your copyright as in: > >> * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com All rights > >> reserved. > >> > >> But if at all possible it would be best if we could not add any > >> more of these, and remove them when possible. > >> > >> > > and that actually I did. thanks > > Rod was saying to remove "All rights reserved" when possible, not the > Copyright line. > No. He's saying 'Add the copyright line after the all rights reserve line so we can start cleaning that mess up.' Don't just remove 'All Rights Reserved from old copyright notices. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrxdyw5WTS9ya4%2BH9ckM7sN1um=j0Jv8eXogxA6VSU=JA>