Date: Mon, 16 Apr 2018 12:05:51 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: Julian Elischer <julian@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com>, Andriy Gapon <avg@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r332559 - head/usr.sbin/mountd Message-ID: <YQBPR0101MB10428504F698BB3B439BCFBCDDB00@YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <5e754f1f-9688-884a-cddd-fa4b65e67f0b@freebsd.org> References: <201804160917.w3G9HaCN081290@repo.freebsd.org> <20180416105611.GG1774@kib.kiev.ua>, <5e754f1f-9688-884a-cddd-fa4b65e67f0b@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer wrote:
>On 16/4/18 6:56 pm, Konstantin Belousov wrote:
[stuff snipped]
>>> + ngroups =3D XU_NGROUPS + 1;
>> Why XU_NGROUPS and not the value of sysctl("kern.ngroups") ?
>valid question.. because that is how many are allocated?
>it was a "minimally invasive patch".. whoever used XU_NGROUPS before
>should have fixed it.
>Having said that, thanks for drawing out attention to it.. will
>probably fix.
16 is the limit specified in the RFCs for Sun RPC, so that is the "on the w=
ire"
limit.
I haven't looked at the code. It might make sense to handle more here and t=
hen
set the limit at 16 after getting rid of duplicates, but I have no idea if =
it matters?
rick
[more stuff snipped]
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YQBPR0101MB10428504F698BB3B439BCFBCDDB00>