Date: Sat, 21 Jul 2001 13:07:56 +0100 From: Brian Somers <brian@Awfulhak.org> To: Hellmuth Michaelis <hm@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@Awfulhak.org Subject: Re: cvs commit: src/share/examples/isdn/i4brunppp i4brunppp.c Message-ID: <200107211207.f6LC7ug71082@hak.lan.Awfulhak.org> In-Reply-To: Message from Hellmuth Michaelis <hm@FreeBSD.org> of "Sat, 21 Jul 2001 04:52:31 PDT." <200107211152.f6LBqWN70603@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> hm 2001/07/21 04:52:31 PDT
>
> Modified files:
> share/examples/isdn/i4brunppp i4brunppp.c
> Log:
> Add a patch from the isdn mailinglist, Juha writes:
>
> ppp in 4.x apparently does a close(2) after opening the tun device;
> i4brunppp starts up with only file descriptors 0 and 1 open (to the rbch
> device) -> tun gets opened as 2 -> tun gets closed -> later use results
> in EBADF. A quick fix to i4brunppp.c makes the thing work (I know, this
> is ugly, but I needed it up quick...):
>
> Submitted by: Juha-Matti Liukkonen <jml@cubical.fi>
>
> Revision Changes Path
> 1.2 +2 -1 src/share/examples/isdn/i4brunppp/i4brunppp.c
This bug has already been fixed and merged into -stable:
----------------------------
revision 1.167.2.7
date: 2001/07/10 21:19:38; author: brian; state: Exp; lines: +19 -2
MFC: Handle descriptors 0, 1 or 2 being closed when ppp is envoked
----------------------------
This i4brunppp.c fix should probably be backed out.
BTW, do you know that sh(1) now supports <> properly ? This program
could probably be converted to a script ending with
exec ppp -direct $ppplabel <> /dev/i4brbch$unit
--
Brian <brian@freebsd-services.com> <brian@Awfulhak.org>
http://www.freebsd-services.com/ <brian@[uk.]FreeBSD.org>
Don't _EVER_ lose your sense of humour ! <brian@[uk.]OpenBSD.org>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200107211207.f6LC7ug71082>