Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Jul 2013 21:33:56 +0300
From:      Mikolaj Golub <trociny@FreeBSD.org>
To:        Craig Rodrigues <rodrigc@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, Marko Zec <zec@fer.hr>
Subject:   Re: svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt
Message-ID:  <20130713183354.GA2832@gmail.com>
In-Reply-To: <CAG=rPVdhjX0SV44vSVTbXq2CAB8xn2%2BXaGW0ywhYJDd9M3tZ5A@mail.gmail.com>
References:  <CAG=rPVcxvWq-MoXADiv%2BgLY-d3hhv1GTMO1R14bhLRm9UB9DqA@mail.gmail.com> <20130712202710.GB2757@gmail.com> <CAJ-Vmomv1nEEq9HV9GreQg6KJGos6ffDhFcVUsUuzfCL6h-YQw@mail.gmail.com> <CAJ-Vmokm29XXbQr5uTwEbGGDYo-8WQNsp60b%2B7Khkteyh%2BO%2B6A@mail.gmail.com> <CAJ-VmomidFufKmGUb0YP2pHWu%2BpF2Os3Fo4JWzkMJDKLqP_ing@mail.gmail.com> <20130713073118.GC2757@gmail.com> <CAG=rPVe_F03LTt1K77p1BSw0hojMm-Ms-oZdhaFgo842AxkmhQ@mail.gmail.com> <20130713111825.GE2757@gmail.com> <20130713141802.GG2757@gmail.com> <CAG=rPVdhjX0SV44vSVTbXq2CAB8xn2%2BXaGW0ywhYJDd9M3tZ5A@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 13, 2013 at 11:04:23AM -0700, Craig Rodrigues wrote:

> Can you try this combination of patches:
> 
> (1)  Combine Adrian and Marko's patches, but omit Marko's changes to
> kldload/kldunload:
> 
> http://people.freebsd.org/~rodrigc/vnet-patch-adrian+marko.txt
> 
> (2)  Revert my Bluetooth patch:
> 
> http://people.freebsd.org/~rodrigc/patch-revert-GRN-253255.txt

Currently I don't have any pluggable device so my testing would not be
very useful. I tried Marko's patch to test kldload/kldunload change,
which is not in your patch.

Concerning your combined patch, as I said previously I don't like very
much that dance with is_default_vnet. What is a purpose of it? As for
me, it only makes the code less readable. I would just set curvnet to
vnet0, as it is in Marko's patch.

-- 
Mikolaj Golub



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130713183354.GA2832>