Date: Fri, 5 Mar 2021 13:36:36 -0500 From: Mark Johnston <markj@freebsd.org> To: Gordon Bergling <gbe@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 89b650872bba - main - ktls: Hide initialization message behind bootverbose Message-ID: <YEJ6NFgwP5kCxz1m@nuc> In-Reply-To: <YEJ3PDT3oOX09z%2BY@lion.0xfce3.net> References: <202103051815.125IFDNK001016@gitrepo.freebsd.org> <YEJ3PDT3oOX09z%2BY@lion.0xfce3.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 05, 2021 at 07:23:56PM +0100, Gordon Bergling wrote: > Hi Mark, > > is this change not a little bit to aggressive in terms of dmesg cleanup? > > There are a lot messages about what subsystem is initialized with > how many threads, like for example TCP HTPS and TCP BBR. I would argue that that is the exception rather than the norm, and they should be cleaned up too. I just didn't notice since they are not compiled into the kernel. We don't log messages about bufspace threads, taskqueue threads, crypto worker threads, NFSD threads, netgraph threads, pagedaemon threads, etc. This is really an implementation detail and I don't see why it's crucial information that needs to be printed upon each boot. Especially in this case, where KTLS needs to be explicitly be enabled before those threads will ever do anything. > Hiding this information could be suboptimal for some users. There is a kern.ipc.tls.stats.threads sysctl which exposes the same number, so I'm not sure it's really hidden. But why would a user need this information? > On Fri, Mar 05, 2021 at 06:15:13PM +0000, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=89b650872bba2e4bfbc94a200946b461ef69ae22 > > > > commit 89b650872bba2e4bfbc94a200946b461ef69ae22 > > Author: Mark Johnston <markj@FreeBSD.org> > > AuthorDate: 2021-03-05 18:11:02 +0000 > > Commit: Mark Johnston <markj@FreeBSD.org> > > CommitDate: 2021-03-05 18:11:02 +0000 > > > > ktls: Hide initialization message behind bootverbose > > > > We don't typically print anything when a subsystem initializes itself, > > and KTLS is currently disabled by default anyway. > > > > Reviewed by: jhb > > MFC after: 1 week > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D29097 > > --- > > sys/kern/uipc_ktls.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/sys/kern/uipc_ktls.c b/sys/kern/uipc_ktls.c > > index 5125061e0879..1fd1eca39b59 100644 > > --- a/sys/kern/uipc_ktls.c > > +++ b/sys/kern/uipc_ktls.c > > @@ -495,7 +495,8 @@ ktls_init(void *dummy __unused) > > } > > } > > > > - printf("KTLS: Initialized %d threads\n", ktls_number_threads); > > + if (bootverbose) > > + printf("KTLS: Initialized %d threads\n", ktls_number_threads); > > } > > SYSINIT(ktls, SI_SUB_SMP + 1, SI_ORDER_ANY, ktls_init, NULL); > > > > _______________________________________________ > > dev-commits-src-main@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main > > To unsubscribe, send any mail to "dev-commits-src-main-unsubscribe@freebsd.org" > > --
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YEJ6NFgwP5kCxz1m>