Date: Sun, 16 May 2010 08:06:51 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Zachary Loafman <zml@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, matthew.fleming@isilon.com Subject: Re: svn commit: r208003 - in head/sys: kern sys Message-ID: <20100516050651.GZ83316@deviant.kiev.zoral.com.ua> In-Reply-To: <201005122124.o4CLOk3b027904@svn.freebsd.org> References: <201005122124.o4CLOk3b027904@svn.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, May 12, 2010 at 09:24:46PM +0000, Zachary Loafman wrote: > Author: zml > Date: Wed May 12 21:24:46 2010 > New Revision: 208003 > URL: http://svn.freebsd.org/changeset/base/208003 > > Log: > Add VOP_ADVLOCKPURGE so that the file system is called when purging > locks (in the case where the VFS impl isn't using lf_*) > > Submitted by: Matthew Fleming <matthew.fleming@isilon.com> > Reviewed by: zml, dfr After looking at what happen to nullfs, see r208003, I wonder why the vop is needed. It is called after VOP_RECLAIM is called by vgonel(), after fs-specific data are destroyed. So, on the one hand, vop can only operate on struct vnode proper, on the other hand, the actions performed by vop_advlockpurge implementation can be done by vop_reclaim as well. Could you, please, give some details on the supposed use of the vop ? [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkvvfWoACgkQC3+MBN1Mb4gXLwCePdawtU3wzHF64fol/6T27b7I 7PgAn0mJbrA0eirA6wYJOpGV7nzaC2KF =E+dx -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100516050651.GZ83316>