Date: Wed, 22 Aug 2018 08:51:24 +0100 From: John Baldwin <jhb@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org>, Matthew Macy <mmacy@freebsd.org>, Andriy Gapon <avg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Johannes Lundberg <johalun0@gmail.com> Subject: Re: svn commit: r338172 - in head: . sys/amd64/conf sys/dev/drm sys/dev/drm2 sys/dev/drm2/i915 sys/dev/drm2/radeon sys/dev/drm2/radeon/reg_srcs sys/dev/drm2/ttm sys/i386/conf sys/modules sys/modules/dr... Message-ID: <860aa5fa-1004-c19e-b928-1cbcc2c90f6f@FreeBSD.org> In-Reply-To: <13c977be-0ee7-688d-4f61-837ccb5d5273@selasky.org> References: <201808220150.w7M1oDeA012487@repo.freebsd.org> <bad9d7c2-2c69-4c1e-fb40-c5dee38d77a1@FreeBSD.org> <CAPrugNq889GHwQv7sXrzRYUZ=GKi8qa9_%2BHky_TOerHz4LKYLA@mail.gmail.com> <13c977be-0ee7-688d-4f61-837ccb5d5273@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/22/18 8:41 AM, Hans Petter Selasky wrote:
> On 8/22/18 9:35 AM, Matthew Macy wrote:
>> Johannes - do you know off hand?
>> -M
>
> Hi,
>
> This function is still not implemented. This is part of the LGPLv2 part.
>
> Probably the function and the restore companion doesn't have to panic.
>
> --HPS
>
>> static inline void
>> linux_pci_save_state(struct pci_dev *pdev)
>> {
>>
>> panic("implment me!!");
>> UNIMPLEMENTED();
>> }
Can't this just use pci_save_state() of the FreeBSD device_t? If there
are bits of PCI space that pci_save_state() isn't saving that we need to
save/restore, we should probably just add those to the FreeBSD one
(e.g. additional capability registers).
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?860aa5fa-1004-c19e-b928-1cbcc2c90f6f>