Date: Sun, 9 Apr 2006 17:35:14 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_socket.c uipc_socket2.c uipc_usrreq.c src/sys/net raw_cb.c raw_usrreq.c rtsock.c src/sys/netatalk ddp_usrreq.c src/sys/netatm atm_aal5.c atm_socket.c atm_usrreq.c atm_var.h src/sys/netgraph ng_socket.c ... Message-ID: <20060409173429.T55490@fledge.watson.org> In-Reply-To: <20060409090541.GG2135@garage.freebsd.pl> References: <200604011542.k31Fg2B3020856@repoman.freebsd.org> <20060409090541.GG2135@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 9 Apr 2006, Pawel Jakub Dawidek wrote:
> +> -static int
> +> +static void
> +> ngd_detach(struct socket *so)
> +> {
> +> struct ngpcb *const pcbp = sotongpcb(so);
> +>
> +> - if (pcbp == NULL)
> +> - return (EINVAL);
> +> + KASSERT(pcbp == NULL, ("ngd_detach: pcbp == NULL"));
>
> From what I see, it should be:
>
> KASSERT(pcbp != NULL, ("ngd_detach: pcbp == NULL"));
This has already been fixed in ng_socket.c:1.73.
Thanks,
Robert N M Watson
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060409173429.T55490>