Date: Thu, 26 Jun 2003 20:25:43 -0700 (PDT) From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/ata ata-card.c Message-ID: <200306270325.h5R3PhqO053229@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
imp 2003/06/26 20:25:43 PDT FreeBSD src repository Modified files: sys/dev/ata ata-card.c Log: Remove check to see if the get resource for the second resource succeeds. There is a difference between how OLDCARD and NEWCARD deal with their resources, and this code exposes that difference. I'm not sure which behavior is correct, and will need to look into that in more detail. However, it appears that we go ahead and allocate the right thing in both cases that I have access to (CF cards, CDROM, and external ata enclosures), so go ahead and ignore the failure to get the resource for the other rid. There's already another check to make sure that the actual allocation works correctly, and that should be sufficient to catch cases that don't work. Submitted by: wpaul and iedowse Revision Changes Path 1.15 +0 -4 src/sys/dev/ata/ata-card.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200306270325.h5R3PhqO053229>