Date: Tue, 05 Apr 2011 21:41:16 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Attilio Rao <attilio@freebsd.org> Cc: freebsd-rc@freebsd.org, Ed Maste <emaste@sandvine.com> Subject: Re: [PATCH] Adding netdumpsrv rc.d script Message-ID: <4D9BEEEC.4050109@FreeBSD.org> In-Reply-To: <BANLkTimmFfYPLpSVM7WHyH=VtjPp=uMJwA@mail.gmail.com> References: <BANLkTimmFfYPLpSVM7WHyH=VtjPp=uMJwA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
The rc.d script and related look fine. The only thing I'd change is a blank line before run_rc_command (a stylistic convention). Don't forget the update to rc.conf.5 as well. hope this helps, Doug On 04/05/2011 13:52, Attilio Rao wrote: > Hello, > I wanted to know if anyone here could review the netdumpsrv script I'm > adding for netdumpsrv. > > netdumpsrv is a daemon that I'm developing on the following project branch: > http://svn.freebsd.org/base/projects/sv/ > > and that I hope to merge to HEAD asap. > > You can have an overview of the man page, for the daemon, here: > http://svn.freebsd.org/base/projects/sv/usr.sbin/netdumpsrv/netdumpsrv.8 > > And this is the rc.d script fixup I want to add: > http://www.freebsd.org/~attilio/Sandvine/STABLE_8/netdump/netdumpsrvrcd.diff > > Any advice would be appreciated. > > Thanks, > Attilio > > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D9BEEEC.4050109>