Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Jan 2021 10:20:45 -0500
From:      Ed Maste <emaste@freebsd.org>
To:        Jessica Clarke <jrtc27@freebsd.org>
Cc:        Mateusz Guzik <mjguzik@gmail.com>, =?UTF-8?Q?Ulrich_Sp=C3=B6rlein?= <uqs@freebsd.org>,  src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org,  dev-commits-src-main@freebsd.org
Subject:   Re: git: a9fc14fbf445 - main - newvers.sh: add support for gitup(1)
Message-ID:  <CAPyFy2DTv_5NdqLJ6YysC=hoy-NzKRpAvsHbbKg8SRRxsJ=rAw@mail.gmail.com>
In-Reply-To: <49353415-D1B2-43D5-AC39-EF64F03EE512@freebsd.org>
References:  <202101200949.10K9nmkZ029085@gitrepo.freebsd.org> <CAGudoHG9KGDH0d23d6F1pCmfApYGFc37ZYmK-gxqgY3Ua_80CA@mail.gmail.com> <CAPyFy2C7jFAP27OW2zHAwoWHpnWpEQTU7tkVpJcMWgTfTGQPHQ@mail.gmail.com> <CAGudoHF8=G1u7n4iQg-DLGGZ7i4Y-5rzgSTHxKs6mS_r2AXD4A@mail.gmail.com> <49353415-D1B2-43D5-AC39-EF64F03EE512@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> > This fixes the problem at hand,

Thanks for confirming, I've fixed that part now.

> > but a new regression is shown:
> >
> > $ strings kernel | grep 'FreeBSD 13.0-ALPHA1'
> > FreeBSD 13.0-ALPHA1 #47 c256181-gb06e91d1b700: Thu Jan 21 14:31:35 UTC 2021
> >
> > branch name is no longer present.
>
> See the commit message, though I'd argue it's not redundant in a lot of
> local development cases (i.e. anything other than main, stable/*, etc),
> and is actually rather useful.

I agree, and my suggestion is that we restore it unconditionally. I
think it's more confusing without a consistent format / set of
components.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2DTv_5NdqLJ6YysC=hoy-NzKRpAvsHbbKg8SRRxsJ=rAw>