Date: Fri, 1 Feb 2002 11:25:36 -0800 (PST) From: Alfred Perlstein <alfred@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern kern_descrip.c Message-ID: <200202011925.g11JPat66504@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
alfred 2002/02/01 11:25:36 PST
Modified files:
sys/kern kern_descrip.c
Log:
Remove bogus assertion in dup2 that can lead to panics when kernel
threads race for a file slot.
dup2(2) incorrectly assumes that if it needs to grow the ofiles
array that it will get what it wants. This assertion was valid
before we allowed shared filedescriptor tables but is now incorrect.
The assertion can trigger superfolous panics if the thread doing a
dup2 looses a race with another thread while possibly blocked in
the MALLOC call in fdalloc. Another thread may grab the slot we
are requesting which makes fdalloc return something other than what
we asked for, this will triggering the bogus assertion.
MFC after: 2 weeks
Reviewed by: phk
Revision Changes Path
1.124 +0 -2 src/sys/kern/kern_descrip.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202011925.g11JPat66504>