Date: Wed, 21 Mar 2018 16:37:49 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Kyle Evans <kevans@freebsd.org>, Andrew Turner <andrew@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331306 - head/sys/dev/usb/controller Message-ID: <b8627a61-adde-a9b4-8cd1-af9435b9ea92@selasky.org> In-Reply-To: <CACNAnaHCf8paMB3RP1SSnP45xPTSKEcJp-qKyKievLE0E_svWA@mail.gmail.com> References: <201803211517.w2LFHsHf007714@repo.freebsd.org> <CACNAnaHCf8paMB3RP1SSnP45xPTSKEcJp-qKyKievLE0E_svWA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/21/18 16:24, Kyle Evans wrote:
>> + {
>> + .ep_end = 7,
>> + .ep_fifosz_shift = 9,
>> + .ep_fifosz_reg = MUSB2_VAL_FIFOSZ_512 | MUSB2_MASK_FIFODB,
>> + },
> I'm afraid I'm not familiar with this- why did .ep_fifosz_shift for
> this case drop to 9? frx = 10 in the temp < 8 case in the removals of
> the following hunks. Mostly curious because the others seemed to stay
> the same.
>
Hi Andrew,
It might be an idea to keep the fifosz_shift at 10, else high-speed BULK
traffic won't be double buffered, and this might affect performance.
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b8627a61-adde-a9b4-8cd1-af9435b9ea92>