Date: Fri, 13 Jul 2007 08:08:54 -0400 From: John Baldwin <jhb@freebsd.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: perforce@freebsd.org, cnst@freebsd.org Subject: Re: PERFORCE change 123172 for review Message-ID: <200707130808.55708.jhb@freebsd.org> In-Reply-To: <20070710.112123.-345495745.imp@bsdimp.com> References: <200707090405.l69456Mw026331@repoman.freebsd.org> <20070710.112123.-345495745.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 10 July 2007 01:21:23 pm M. Warner Losh wrote: > In message: <200707090405.l69456Mw026331@repoman.freebsd.org> > "Constantine A. Murenin" <cnst@freebsd.org> writes: > : http://perforce.freebsd.org/chv.cgi?CH=123172 > : > : Change 123172 by cnst@dale on 2007/07/09 04:04:33 > : > : print nameunit before chip name, which wasn't printed > : because on OpenBSD lm produced only one line in dmesg > : > : On OpenBSD: > : lm0 at isa0 port 0x290/8: W83627DHG > : > : Now on FreeBSD: > : lm0 at port 0x290 on isa0 > : lm0: W83627DHG > > You should be setting the device description to W83627DHG if at all > possible. That will result in: > > lm0: <W83627DHG> at port 0x290 on isa0 Also, in general you should use device_printf(). That is use: device_printf(dev, "%s\n", my_string); rather than: printf("%s: ", device_get_nameunit(dev)); ... printf("%s\n", my_string); This does look like you need to use device_set_desc() in your probe routine though. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707130808.55708.jhb>