Date: 07 Dec 2001 15:13:20 +0100 From: Dag-Erling Smorgrav <des@ofug.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Peter Wemm <peter@FreeBSD.org>, Mark Murray <markm@FreeBSD.org>, Bruce Evans <bde@FreeBSD.org> Subject: Re: PAM, libssh, and all that (was: Re: cvs commit: src/lib/libpam/modules/pam_ssh pam_ssh.c) Message-ID: <xzpu1v315kv.fsf@flood.ping.uio.no> In-Reply-To: <20011207160554.C65808@sunbay.com> References: <200112071151.fB7BplS52145@freefall.freebsd.org> <20011207155257.A65808@sunbay.com> <xzpy9kf167h.fsf@flood.ping.uio.no> <20011207160554.C65808@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov <ru@FreeBSD.org> writes: > On Fri, Dec 07, 2001 at 02:59:46PM +0100, Dag-Erling Smorgrav wrote: > > Ruslan Ermilov <ru@FreeBSD.org> writes: > > > On Fri, Dec 07, 2001 at 03:51:47AM -0800, Dag-Erling Smorgrav wrote: > > > > Log: > > > > Get pam_mod_misc.h from .CURDIR rather than .OBJDIR or /usr/include. > > > Um, why?! > > Because that's the way the other modules do it, and in some > > circumstances, pam_ssh won't build at all without this change. > Look, I asked "why". Please tell us your fellow developers why > this was needed. I fail to see the reason myself. Is it so hard? When building libpam separately (not as part of a world build), pam_ssh will incorrectly use the copy of pam_mod_misc.h from /usr/include instead of the one from the source tree. Since you have to build the modules before the library (because they're linked into the static library), if you introduce a non-backward-compatible change in pam_mod_misc.h or nuke /usr/include/security before building, pam_ssh won't build. All the other modules get this right by including "pam_mod_misc.h" instead of <security/pam_mod_misc.h>. An alternative fix would be to repocopy pam_mod_misc.h into src/lib/libpam/libpam/security and fix the Makefiles accordingly; all modules could then #include <security/pam_mod_misc.h> and get the right version of pam_mod_misc.h. This was my initial intention, but cvs@ asked me to change pam_ssh.c instead. > > > On a side note, with recent pam.d changes, something is seriously > > > screwed. I don't have USE_PAM_D setting in my make.conf(5), and > > > on a freshly build 5.0-CURRENT I hereby have an empty /etc/pam.d. > > > Every attempt to use su(1) results in: > > > [...] > > Already fixed. > Which commit fixed it, specifically? Revision 1.4 of pam_handlers.c. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpu1v315kv.fsf>