Date: Thu, 22 Jun 2017 14:34:02 -0400 From: Ed Maste <emaste@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r320234 - head/sys/boot/efi/include Message-ID: <CAPyFy2CoYTSTbOXJprvHYkjcUWADjrz515vcgUuC%2BmZ98iR6xw@mail.gmail.com> In-Reply-To: <1F8C5886-71FC-486B-9793-E3554843CC65@FreeBSD.org> References: <201706221430.v5MEU9Zc063375@repo.freebsd.org> <1F8C5886-71FC-486B-9793-E3554843CC65@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22 June 2017 at 14:23, Dimitry Andric <dim@freebsd.org> wrote:
>> Modified: head/sys/boot/efi/include/efidef.h
>> ==============================================================================
>> --- head/sys/boot/efi/include/efidef.h Thu Jun 22 13:31:44 2017 (r320233)
>> +++ head/sys/boot/efi/include/efidef.h Thu Jun 22 14:30:09 2017 (r320234)
>> @@ -178,6 +178,7 @@ typedef enum {
>> #define EFI_MEMORY_DESCRIPTOR_VERSION 1
>> typedef struct {
>> UINT32 Type; // Field size is 32 bits followed by 32 bit pad
>> + UINT32 Pad;
>> EFI_PHYSICAL_ADDRESS PhysicalStart; // Field size is 64 bits
>> EFI_VIRTUAL_ADDRESS VirtualStart; // Field size is 64 bits
>> UINT64 NumberOfPages; // Field size is 64 bits
>
> If you explicitly insert padding, it is better to mark the struct as
> __packed, I think. Or at least also specify the alignment explicitly.
Perhaps, although this struct now matches the definition in the edk
and u-boot EFI headers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CoYTSTbOXJprvHYkjcUWADjrz515vcgUuC%2BmZ98iR6xw>