Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Jul 2009 14:09:33 GMT
From:      Sylvestre Gallon <syl@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 166007 for review
Message-ID:  <200907131409.n6DE9Xik002337@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=166007

Change 166007 by syl@syl_pablo on 2009/07/13 14:09:03

	remove isochronous code. This Ip does not support isochronous.
	Call s3c24dci_device_done in s3c24dci_device_xxx_close.

Affected files ...

.. //depot/projects/soc2009/syl_usb/src/sys/dev/usb/controller/s3c24xxdci.c#6 edit

Differences ...

==== //depot/projects/soc2009/syl_usb/src/sys/dev/usb/controller/s3c24xxdci.c#6 (text+ko) ====

@@ -176,6 +176,7 @@
 static void
 s3c24dci_device_ctrl_close(struct usb_xfer *xfer)
 {
+	s3c24dci_device_done(xfer, USB_ERR_CANCELLED);
 	return ;
 }
 
@@ -211,6 +212,7 @@
 static void
 s3c24dci_device_bulk_close(struct usb_xfer *xfer)
 {
+	s3c24dci_device_done(xfer, USB_ERR_CANCELLED);
 	return ;
 }
 
@@ -246,6 +248,7 @@
 static void
 s3c24dci_device_intr_close(struct usb_xfer *xfer)
 {
+	s3c24dci_device_done(xfer, USB_ERR_CANCELLED);
 	return ;
 }
 
@@ -269,41 +272,6 @@
 };
 
 /*
- * s3c24xxdci isochronous support
- */
-
-static void
-s3c24dci_device_isoc_fs_open(struct usb_xfer *xfer)
-{
-	return ;
-}
-
-static void
-s3c24dci_device_isoc_fs_close(struct usb_xfer *xfer)
-{
-	return ;
-}
-
-static void
-s3c24dci_device_isoc_fs_start(struct usb_xfer *xfer)
-{
-	return ;
-}
-
-static void
-s3c24dci_device_isoc_fs_enter(struct usb_xfer *xfer)
-{
-	return ;
-}
-
-struct usb_pipe_methods s3c24dci_device_bulk_methods = {
-	.open = s3c24dci_device_isoc_fs_open,
-	.close = s3c24dci_device_isoc_fs_close,
-	.enter = s3c24dci_device_isoc_fs_enter,
-	.start = s3c24dci_device_isoc_fs_start,
-};
-
-/*
  * USB FN interface
  */
 
@@ -511,9 +479,6 @@
 		case UE_INTERRUPT:
 			ep->methods = &s3c24dci_device_intr_methods;
 			break ;
-		case UE_ISOCHRONOUS:
-			ep->methods = &s3c24dci_device_isoc_fs_methods;
-			break ;
 		case UE_BULK:
 			ep->methods = &s3c24dci_device_bulk_methods;
 			break ;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907131409.n6DE9Xik002337>