Date: Thu, 28 Jun 2007 05:41:44 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Xin LI <delphij@delphij.net> Cc: src-committers@FreeBSD.org, Harti Brandt <harti@FreeBSD.org>, Andrey Chernov <ache@nagual.pp.ru>, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, Kostik Belousov <kostikbel@gmail.com> Subject: Re: cvs commit: src/share/mk sys.mk Message-ID: <20070628053644.A74728@delplex.bde.org> In-Reply-To: <46826A8C.8070908@delphij.net> References: <200706261910.l5QJALb8093717@repoman.freebsd.org> <20070627093610.GU2268@deviant.kiev.zoral.com.ua> <20070627113859.N64822@knop-beagle.kn.op.dlr.de> <20070627101148.GB44554@nagual.pp.ru> <46826A8C.8070908@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 27 Jun 2007, Xin LI wrote: > Andrey Chernov wrote: >> I just sent this cross-building compatible variant to re@ for approve: >> >> --- sys.mk.orig 2007-06-27 14:04:15.000000000 +0400 >> +++ sys.mk 2007-06-27 14:04:33.000000000 +0400 >> @@ -35,7 +35,7 @@ >> CFLAGS ?= -O >> .else >> CC ?= cc >> -CFLAGS ?= -O2 -fno-strict-aliasing -fno-tree-vrp -pipe >> +CFLAGS ?= -O1 -fno-strict-aliasing -pipe >> .endif > > Nitpicking: I think -O1 implies no strict-aliasing. So -O1 -pipe might > be just Ok. Still has a style bug: -O implies -O. If changing it, back out the commit that changed it from -O. I still use -O in most cases since -O2 is just a waste of time in most cases. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070628053644.A74728>