Date: Sun, 2 Mar 2014 18:00:01 -0500 From: Julio Merino <jmmv@freebsd.org> To: Garrett Cooper <yanegomi@gmail.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Pawel Jakub Dawidek <pjd@freebsd.org> Subject: Re: [PATCH] Integrate pjdfstest into the build Message-ID: <CAFY7cWCme4QTbo86uQhJ_DFLb9Z6dfWaj_%2Bs9m-tWFw35Vx%2BAQ@mail.gmail.com> In-Reply-To: <56D809A7-5387-475A-8C89-794E328F6935@gmail.com> References: <94D3F60A-1E12-418B-8313-E43C93878B95@gmail.com> <CAFY7cWDsR=82ANK8q2-SoVyu6BowdC6hHDwo%2Bs1P7Jt%2Bfy8ZCQ@mail.gmail.com> <56D809A7-5387-475A-8C89-794E328F6935@gmail.com>
index | next in thread | previous in thread | raw e-mail
On Sun, Mar 2, 2014 at 5:54 PM, Garrett Cooper <yanegomi@gmail.com> wrote: >> * The test files should move from tools/regression/pjdfstest/ into the >> new location under tests/sys/ and be renamed to follow the conventions >> under src/test (e.g. xx.t -> xx_test). > > Please talk to Pawel about this. These tests have been developed and are maintained (to some degree) outside FreeBSD: https://github.com/pjd/pjdfstest . I'd rather treat this as an integration of the 3rd party package, not a refactor. If you want me to install the tests like _test though, I'd be more than happy to do that. Ah great; that's what I suspected given the mentions of other OSes in the code! Then I believe this should really live under contrib/pjdfstest. Any reason it's not there? If it's external, then yes, we should keep the layout of the upstream sources without performing any renames (unless Pawel wants to do them). Thankshome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFY7cWCme4QTbo86uQhJ_DFLb9Z6dfWaj_%2Bs9m-tWFw35Vx%2BAQ>