Date: Fri, 07 Sep 2001 01:27:10 +0100 From: Brian Somers <brian@freebsd-services.com> To: Poul-Henning Kamp <phk@critter.freebsd.dk>, "Andrey A. Chernov" <ache@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Brian Somers <brian@freebsd-services.com> Subject: Re: cvs commit: src/lib/libc/stdio fdopen.c fflush.c fopen.c fseek.c ftell.c fvwrite.c local.h refill.c stdio.c Message-ID: <200109070027.f870RAD48771@hak.lan.Awfulhak.org> In-Reply-To: Message from Poul-Henning Kamp <phk@critter.freebsd.dk> of "Mon, 03 Sep 2001 07:26:53 %2B0200." <20159.999494813@critter>
next in thread | previous in thread | raw e-mail | index | archive | help
> In message <200109021910.f82JACD82362@freefall.freebsd.org>, "Andrey A. Chernov
> " writes:
> >ache 2001/09/02 12:10:12 PDT
> >
> > Modified files:
> > lib/libc/stdio fdopen.c fflush.c fopen.c fseek.c ftell.c
> > fvwrite.c local.h refill.c stdio.c
> > Log:
> > Move all stdio internal flags processing and setting out of __sread(),
> > __swrite() and __sseek() to higher level. According to funopen(3) they all
> > are just wrappers to something like standard read(2), write(2) and
> > lseek(2), i.e. must not touch stdio internals because they are replaceable
> > with any other functions knows nothing about stdio internals. See example
> > of funopen(3) usage in sendmail sources f.e.
> >
> > NOTE: this is original stdio bug, not result of my range checkin added.
>
> NOTE: You forgot to add "Reviewed by: xxx"
>
> Or do you seriously think that mucking about in STDIO doesn't need
> a review ?
In this case I think it does. This commit broke ppp.
To reproduce the problem:
$ ppp
Working in interactive mode
Using interface: tun1
ppp ON hak> set server 1234 hello
ppp ON hak> ^Z
[1]+ Stopped ppp
$ bg
[1]+ ppp &
$ pppctl 1234
And it just hangs there.
Can you please either fix this or back the change out Andrey ?
> --
> Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
> phk@FreeBSD.ORG | TCP/IP since RFC 956
> FreeBSD committer | BSD since 4.3-tahoe
> Never attribute to malice what can adequately be explained by incompetence.
--
Brian <brian@freebsd-services.com> <brian@Awfulhak.org>
http://www.freebsd-services.com/ <brian@[uk.]FreeBSD.org>
Don't _EVER_ lose your sense of humour ! <brian@[uk.]OpenBSD.org>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200109070027.f870RAD48771>