Date: Wed, 14 Jan 2009 19:23:01 -0800 From: Andrew Thompson <thompsa@FreeBSD.org> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187260 - head/sys/conf Message-ID: <20090115032301.GA78451@citylink.fud.org.nz> In-Reply-To: <200901150241.n0F2fQ7B060823@svn.freebsd.org> References: <200901150241.n0F2fQ7B060823@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 15, 2009 at 02:41:26AM +0000, Craig Rodrigues wrote: > Author: rodrigc > Date: Thu Jan 15 02:41:26 2009 > New Revision: 187260 > URL: http://svn.freebsd.org/changeset/base/187260 > > Log: > When building up the command-line for the DTrace ctfmerge and ctfconvert > utilities, add the ${DEBUG} variable from the kernel config. Otherwise, > if we build a kernel with WITH_CTF=1 set, ctfmerge will not have > the -g flag set. In this case, the cc has -g specified, so the > .o files will have debug information generated, but since ctfmerge > does not have -g set, it will strip out the ELF sections containing > the DWARF debugging info, leading to a kernel without debugging symbols. > > Reviewed by: jb > > Modified: > head/sys/conf/kern.pre.mk > > Modified: head/sys/conf/kern.pre.mk > ============================================================================== > --- head/sys/conf/kern.pre.mk Thu Jan 15 02:35:40 2009 (r187259) > +++ head/sys/conf/kern.pre.mk Thu Jan 15 02:41:26 2009 (r187260) > @@ -129,7 +129,7 @@ NORMAL_M= ${AWK} -f $S/tools/makeobjops. > ${CC} -c ${CFLAGS} ${WERROR} ${PROF} ${.PREFIX}.c > > .if defined(CTFCONVERT) > -NORMAL_CTFCONVERT= ${CTFCONVERT} ${CTFFLAGS} ${.TARGET} > +NORMAL_CTFCONVERT= ${CTFCONVERT} ${DEBUG} ${CTFFLAGS} ${.TARGET} It seems this was also a few days ago fixed by http://svn.freebsd.org/changeset/base/187103 One of which is now redundant? Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090115032301.GA78451>