Date: Thu, 28 Oct 2004 10:52:57 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Dirk Meyer <dinoex@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/x11-toolkits/tk84 Makefile Message-ID: <20041028175256.GB67234@xor.obsecurity.org> In-Reply-To: <200410281708.i9SH8rDZ094833@repoman.freebsd.org> References: <200410281708.i9SH8rDZ094833@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--pvezYHf7grwyp3Bc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Oct 28, 2004 at 05:08:53PM +0000, Dirk Meyer wrote:
> dinoex 2004-10-28 17:08:53 UTC
>=20
> FreeBSD ports repository
>=20
> Modified files:
> x11-toolkits/tk84 Makefile=20
> Log:
> - detect unsupported configuration
It is supported, so this commit is incorrect too. Please take the
time to think through the problem, including the feedback you've
received, instead of making a rash of broken commits in your haste to
fix it. Testing your changes would also be good.
Kris
> | +TCL_CHECK!=3D ( cd ${PORTSDIR}/${PKGCATEGORY}/${TCL84_PORT} && make WR=
KDIRPREFIX=3D -V WRKSRC | sed -e 's|/unix$$||' )
> | +
> | pre-everything::
> | @if ${TEST} -e "${NONEXISTENT}"; then ${ECHO_MSG} "=3D=3D=3D Aborted,=
please remove ${NONEXISTENT}"; exit 1; fi
> | =20
> | @@ -366,6 +368,7 @@ post-configure:
> | ${REINPLACE_CMD} -e 's|^MAN_INSTALL_DIR.*$$|MAN_INSTALL_DIR =3D ${WRK=
DIR}|' \
> | ${WRKSRC}/Makefile
> | .endif
> | + @if ! grep "TCL_SRC_DIR=3D.\$${WRKDIRPREFIX}${TCL_CHECK}" "${LOCALBAS=
E}/lib/tcl8.4/tclConfig.sh"; then ${ECHO_MSG} "=3D=3D=3D Aborted, this conf=
iguration is not supported, set PORTSDIR and rebuild tcl84"; exit 1; fi
> | =20
> | post-install:
> | ${INSTALL_DATA} ${FILESDIR}/pkgIndex.tcl ${PREFIX}/lib/tk${TK_VER}/
>=20
--pvezYHf7grwyp3Bc
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQFBgTH4Wry0BWjoQKURAkXpAKDkD22WOEYeh2XAacMLU+vP9valKACfTxNK
cAhkxisD6e5kYQxUIJgpuaQ=
=laTB
-----END PGP SIGNATURE-----
--pvezYHf7grwyp3Bc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041028175256.GB67234>