Date: Thu, 28 Oct 2004 10:52:57 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Dirk Meyer <dinoex@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/x11-toolkits/tk84 Makefile Message-ID: <20041028175256.GB67234@xor.obsecurity.org> In-Reply-To: <200410281708.i9SH8rDZ094833@repoman.freebsd.org> References: <200410281708.i9SH8rDZ094833@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Oct 28, 2004 at 05:08:53PM +0000, Dirk Meyer wrote:
> dinoex 2004-10-28 17:08:53 UTC
>
> FreeBSD ports repository
>
> Modified files:
> x11-toolkits/tk84 Makefile
> Log:
> - detect unsupported configuration
It is supported, so this commit is incorrect too. Please take the
time to think through the problem, including the feedback you've
received, instead of making a rash of broken commits in your haste to
fix it. Testing your changes would also be good.
Kris
> | +TCL_CHECK!= ( cd ${PORTSDIR}/${PKGCATEGORY}/${TCL84_PORT} && make WRKDIRPREFIX= -V WRKSRC | sed -e 's|/unix$$||' )
> | +
> | pre-everything::
> | @if ${TEST} -e "${NONEXISTENT}"; then ${ECHO_MSG} "=== Aborted, please remove ${NONEXISTENT}"; exit 1; fi
> |
> | @@ -366,6 +368,7 @@ post-configure:
> | ${REINPLACE_CMD} -e 's|^MAN_INSTALL_DIR.*$$|MAN_INSTALL_DIR = ${WRKDIR}|' \
> | ${WRKSRC}/Makefile
> | .endif
> | + @if ! grep "TCL_SRC_DIR=.\$${WRKDIRPREFIX}${TCL_CHECK}" "${LOCALBASE}/lib/tcl8.4/tclConfig.sh"; then ${ECHO_MSG} "=== Aborted, this configuration is not supported, set PORTSDIR and rebuild tcl84"; exit 1; fi
> |
> | post-install:
> | ${INSTALL_DATA} ${FILESDIR}/pkgIndex.tcl ${PREFIX}/lib/tk${TK_VER}/
>
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQFBgTH4Wry0BWjoQKURAkXpAKDkD22WOEYeh2XAacMLU+vP9valKACfTxNK
cAhkxisD6e5kYQxUIJgpuaQ=
=laTB
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041028175256.GB67234>