Date: Fri, 14 Nov 2003 12:33:14 -0800 From: Sam Leffler <sam@errno.com> To: Nate Lawson <nate@root.org>, Sam Leffler <sam@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/an if_an.c if_anreg.h src/sys/dev/bfe if_bfe.c src/sys/dev/my if_my.c src/sys/dev/owi if_owi.c if_wivar.h src/sys/dev/re if_re.c src/sys/dev/wl if_wl.c Message-ID: <200311141233.14513.sam@errno.com> In-Reply-To: <20031114121752.V48322@root.org> References: <20031114190111.EDAC816A4E2@hub.freebsd.org> <20031114121752.V48322@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 14 November 2003 12:21 pm, Nate Lawson wrote: > On Fri, 14 Nov 2003, Sam Leffler wrote: > > Modified files: > > sys/dev/an if_an.c if_anreg.h > > sys/dev/bfe if_bfe.c > > sys/dev/my if_my.c > > sys/dev/owi if_owi.c if_wivar.h > > sys/dev/re if_re.c > > sys/dev/wl if_wl.c > > sys/pci if_dc.c if_dcreg.h if_pcn.c if_pcnreg.h > > if_rl.c if_rlreg.h if_sf.c if_sfreg.h > > if_sis.c if_sisreg.h if_sk.c if_skreg.h > > if_ste.c if_stereg.h if_ti.c if_tireg.h > > if_tl.c if_tlreg.h if_vr.c if_vrreg.h > > if_wb.c if_wbreg.h if_xl.c if_xlreg.h > > Log: > > Drop the driver lock around calls to if_input to avoid a LOR when > > the packets are immediately returned for sending (e.g. when bridging > > or packet forwarding). There are more efficient ways to do this > > but for now use the least intrusive approach. > > > > Reviewed by: imp, rwatson > > FYI, I believe fxp(4) already has this fix. Yes, several drivers already do this; I just did a sweep through the remaining drivers that were locked to make them all do the same thing. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200311141233.14513.sam>