Date: Sat, 14 Jun 2008 14:34:04 +0200 From: Marcin Cieslak <saper@SYSTEM.PL> To: Jeremy Messenger <mezz7@cox.net> Cc: cvs-ports@freebsd.org, ports-committers@freebsd.org, cvs-all@freebsd.org, Edwin Groothuis <edwin@freebsd.org> Subject: Re: cvs commit: ports/net/tn5250j Makefile Message-ID: <4853BABC.2040500@SYSTEM.PL> In-Reply-To: <op.ucp4j6p09aq2h7@mezz.mezzweb.com> References: <200806132211.m5DMBONf038311@repoman.freebsd.org> <op.ucpk0aid9aq2h7@mezz.mezzweb.com> <48532AFC.4030004@SYSTEM.PL> <op.ucp4j6p09aq2h7@mezz.mezzweb.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
Jeremy Messenger wrote:
> On Fri, 13 Jun 2008 21:20:44 -0500, Marcin Cieslak <saper@system.pl> wrote:
>
>> Jeremy Messenger wrote:
>>> Do that need to be check careful. I rather to avoid use ${BUILD_DEPENDS}
>>> and do the copy-n-paste full lines instead. Are zip and ant need to be
>>> in the runtime dependency? The ${BUILD_DEPENDS} causes USE_*=yes to be
>>> include in the runtime dependency.
>>
>> No, zip is needed only to unpack the distfile, ant is only needed to
>> build the stuff (it's just like "make").
>
> # make run-depends-list | grep ant
> /usr/ports/devel/apache-ant
>
That's exactly the reason why RUN_DEPENDS= ${BUILD_DEPENDS} is wrong :-(
Thanks for pointing out.
There I would propose another patch:
retrieving revision 1.1
diff -u -u -r1.1 Makefile
--- Makefile 13 Jun 2008 02:37:00 -0000 1.1
+++ Makefile 14 Jun 2008 12:31:54 -0000
@@ -17,8 +17,13 @@
BUILD_DEPENDS= ${JAVAJARDIR}/mail.jar:${PORTSDIR}/java/javamail \
${JYTHON_JAR}:${PORTSDIR}/lang/jython \
- ${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen
-RUN_DEPENDS= ${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \
+ ${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen \
+ ${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \
+ ${JAVAJARDIR}/log4j.jar:${PORTSDIR}/devel/log4j
+RUN_DEPENDS= ${JAVAJARDIR}/mail.jar:${PORTSDIR}/java/javamail \
+ ${JYTHON_JAR}:${PORTSDIR}/lang/jython \
+ ${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen \
+ ${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \
${JAVAJARDIR}/log4j.jar:${PORTSDIR}/devel/log4j
USE_ZIP= yes
--
<< Marcin Cieslak // saper@system.pl >>
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQCVAwUBSFO6vz2W2v2wY27ZAQPFqAP/SIP3mMOp+bGD8x9AB6d+lh/3xQ1vZEM/
YRz+ohxL9lJqkCwxz6766SsW487RQxTDYGVNmMbEkKkv6+NTHC5rpb0PXaNiWkU6
XKqqleTykXVJeMehNuSFFPratJqigeYDuvryJAzqQYC9o8aJRvofW0MXyQx5VEPi
KAk+J/jS1XY=
=3Xtc
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4853BABC.2040500>