Date: Mon, 13 Sep 2004 11:35:47 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Scott Long <scottl@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 pmap.c src/sys/kern sched_4bsd.c sched_ule.c src/sys/sys proc.h sched.h Message-ID: <200409131135.48194.jhb@FreeBSD.org> In-Reply-To: <200409111007.i8BA7MeA090701@repoman.freebsd.org> References: <200409111007.i8BA7MeA090701@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 11 September 2004 06:07 am, Scott Long wrote: > scottl 2004-09-11 10:07:22 UTC > > FreeBSD src repository > > Modified files: > sys/i386/i386 pmap.c > sys/kern sched_4bsd.c sched_ule.c > sys/sys proc.h sched.h > Log: > Revert the previous round of changes to td_pinned. The scheduler isn't > fully initialed when the pmap layer tries to call sched_pini() early in > the boot and results in an quick panic. Use ke_pinned instead as was > originally done with Tor's patch. > > Approved by: julian Thanks, I think td_pinned belongs in struct thread just as td_critnest. Not all parts of the scheduler purely live in sched_foo.c. Arguably things sleep queues are also part of the scheduler since they deal with queues of threads and manipulating thread state machines, so I think that while some things should be private to sched_foo, not everything has to be completely private. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409131135.48194.jhb>