Date: Mon, 17 Dec 2001 11:20:38 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Mark Murray <mark@grondar.za> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/rm rm.c src/usr.sbin/chown chown.c src/usr.sbin/dev_mkdb dev_mkdb.c Message-ID: <20011217112037.B47617@sunbay.com> In-Reply-To: <200112141930.fBEJUJU06523@grimreaper.grondar.org> References: <20011214204055.I16945@sunbay.com> <200112141930.fBEJUJU06523@grimreaper.grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 14, 2001 at 07:30:19PM +0000, Mark Murray wrote:
> > I was mostly joking actually, didn't expect that people REALLY
> > do this. Mark, may I know where this has been discussed, as
> > the only one I recall is that not prototyping main() is OK,
> > as its prototype is internally known to almost every compiler.
>
> This was not discussed per se. I just turned on WARNS=2 and fixed the
> warnings. If the compiler whined about main(), then I fixed that too.
>
Perhaps you did it at the times our compiler was broken?
See how backing out such a change now doesn't break anything:
Index: chflags.c
===================================================================
RCS file: /home/ncvs/src/usr.bin/chflags/chflags.c,v
retrieving revision 1.13
diff -u -p -r1.13 chflags.c
--- chflags.c 2001/12/10 21:13:03 1.13
+++ chflags.c 2001/12/17 09:20:53
@@ -57,7 +57,6 @@ __FBSDID("$FreeBSD: src/usr.bin/chflags/
#include <string.h>
#include <unistd.h>
-int main __P((int, char *[]));
void usage __P((void));
int
--
Ruslan Ermilov Oracle Developer/DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011217112037.B47617>