Date: Wed, 18 Sep 2002 17:08:10 +0300 From: Peter Pentchev <roam@ringlet.net> To: Dan Langille <dan@langille.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/devel/gindent Makefile pkg-plist ports/devel/gindent/files patch-doc:Makefile.in Message-ID: <20020918140809.GB13373@straylight.oblivion.bg> In-Reply-To: <3D88438C.16000.41888E90@localhost> References: <200209181232.g8ICWbq4059604@freefall.freebsd.org> <3D88438C.16000.41888E90@localhost>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Sep 18, 2002 at 09:12:44AM -0400, Dan Langille wrote: > On 18 Sep 2002 at 5:32, Peter Pentchev wrote: > > > roam 2002/09/18 05:32:37 PDT > > > > Modified files: > > devel/gindent Makefile pkg-plist > > devel/gindent/files patch-doc:Makefile.in > > Log: > > Support CFLAGS/CXXFLAGS properly. > > Honor NOPORTDOCS. > > Waking up this morning, FreshPorts tells me[1] there is a problem > with this port: > > [dan@undef:~/ports/devel/gindent] $ make -V PORTVERSION > "/usr/home/dan/ports/devel/gindent/Makefile", line 36: Malformed > conditional (!defiend(NOPORTDOCS)) Yeah, well.. *censored*.. I guess that serves me well for trying to fix an obvious omission on the PR submitter's part (no .ifdef NOPORTDOCS around the post-install target) right before the commit, with not even an attempt at a test :( OK, I will fix it as soon as we're done with some FreshPorts tests that Dan has asked me to help with. [snip] > [1] - FreshPorts would have told roam if he was opt'd in at > FreshPorts. FreshPorts runs a sanity test on every port commit. If > a commiter opts in, any errors found in their commits are reported > directly to them instead of me being the go between. I urge every > port committer to opt in. It saves me the bother of reporting your > errors to you and the world. It also means the problem is fixed much > sooner. At present, we have 15 opt'd in committers, where are the > rest of you? And although I had to learn about this FreshPorts service the hard way, may I use this opportunity to join Dan in his plea. This is indeed a good service, almost real-time notification of both trivial errors and obscure things like the pre-everything double-colon problems of yore. Just jump in and do it :) G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 I am jealous of the first word in this sentence. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE9iIjJ7Ri2jRYZRVMRAkgFAJ9KG0K3h3KybWMKOMgNzJypGynQawCfZUHV 3ZwShonDQSmaOaLzGLMCRCA= =p4fk -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020918140809.GB13373>