Date: Thu, 20 Jul 2000 17:31:16 +0100 From: Brian Somers <brian@Awfulhak.org> To: Sheldon Hearn <sheldonh@uunet.co.za> Cc: Brian Somers <brian@Awfulhak.org>, Jordan Hubbard <jkh@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Brian Somers <brian@FreeBSD.org>, shin@FreeBSD.org, brian@Awfulhak.org Subject: Re: cvs commit: src/lib/libc/net rcmd.3 rcmd.c Message-ID: <200007201631.RAA03447@hak.lan.Awfulhak.org> In-Reply-To: Message from Sheldon Hearn <sheldonh@uunet.co.za> of "Thu, 20 Jul 2000 16:08:07 %2B0200." <4245.964102087@axl.ops.uunet.co.za>
next in thread | previous in thread | raw e-mail | index | archive | help
> > > On Thu, 20 Jul 2000 15:01:05 +0100, Brian Somers wrote: > > > The alternative would be to bump __FreeBSD_version for this purpose. > > > > Whaddaya think ? > > >From what I understand of your feedback, it doesn't seem that a version > bump is going to solve anything for anyone -- neither old code nor new. > Unless I've gone mad and it's illegal to try to free a NULL pointer. :-) > > Oh hang on... When rcmd() and rcmd_af() free the ahost allocations, do > they set the pointer to NULL afterwards? If not, they should, and then > we have no problem but the unavoidable memory leaks for old code. The don't set *ahost to NULL, it remains pointing to the free()d memory :-( > Ciao, > Sheldon. > -- Brian <brian@Awfulhak.org> <brian@[uk.]FreeBSD.org> <http://www.Awfulhak.org> <brian@[uk.]OpenBSD.org> Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200007201631.RAA03447>