Date: Mon, 7 Jun 2004 10:52:58 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Gleb Smirnoff <glebius@cell.sick.ru> Cc: net@FreeBSD.org Subject: Re: HEADSUP! netgraph Metadata changing. Message-ID: <20040607075258.GA642@ip.net.ua> In-Reply-To: <20040607074410.GC18232@cell.sick.ru> References: <Pine.BSF.4.21.0406061825360.15217-100000@InterJet.elischer.org> <20040607071701.GC17986@cell.sick.ru> <20040607073812.GA339@ip.net.ua> <20040607074410.GC18232@cell.sick.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Mon, Jun 07, 2004 at 11:44:10AM +0400, Gleb Smirnoff wrote:
> On Mon, Jun 07, 2004 at 10:38:12AM +0300, Ruslan Ermilov wrote:
> R> On Mon, Jun 07, 2004 at 11:17:01AM +0400, Gleb Smirnoff wrote:
> R> > On Sun, Jun 06, 2004 at 06:35:51PM -0700, Julian Elischer wrote:
> R> > J> In addition the ng_ksocket node adds info into metadata and I suspect
> R> > J> there are people using that.
> R> >
> R> > Since ng_ksocket tags packets for itself only, we can safely change it.
> R> >
> R> I use this feature in one proprietary module (need to send/recevive
> R> UDP datagrams to/from different destinations).
>
> Does your module reads/writes meta?
>
It does, in its "rcvdata" method:
NG_FREE_META(meta);
len = sizeof(*meta) + sizeof(*mhead) + sizeof(*sin);
MALLOC(meta, meta_p, len, M_NETGRAPH,
M_NOWAIT | M_ZERO);
if (meta == NULL) {
NG_FREE_M(m);
return (ENOMEM);
}
...
Yes, the change will break it. No, I'm not opposed to a change.
I was just commenting on the "for itself" bit, it's not true.
Cheers,
--
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAxB7aqRfpzJluFF4RAm8fAJ9L/Iyt+NzOiwDQ7JJDBr1LtajPJwCcDxt9
+nFN+L2atAGZV2RgYiFG96U=
=1Ivc
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040607075258.GA642>