Date: Thu, 03 Aug 2006 17:34:10 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: "Simon L. Nielsen" <simon@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/tools/nanobsd nanobsd.sh Message-ID: <49150.1154626450@critter.freebsd.dk> In-Reply-To: Your message of "Thu, 03 Aug 2006 14:05:16 %2B0200." <20060803120515.GA1223@zaphod.nitro.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20060803120515.GA1223@zaphod.nitro.dk>, "Simon L. Nielsen" writes: >On 2006.07.13 14:06:10 +0000, Poul-Henning Kamp wrote: >> phk 2006-07-13 14:06:10 UTC >> >> FreeBSD src repository >> >> Modified files: >> tools/tools/nanobsd nanobsd.sh >> Log: >> Create the diskless magic files in /etc during the install_etc() step >> instead of setup_nanobsd(), because this gives customize tasks a chance >> to fiddle the details. > >This makes it a bit harder to (ab)use nanobsd.sh as a framework to >build more normal FreeBSD images where a normal /etc is used. >Previously I simply replaced setup_nanobsd in my customize script and >I got a pretty standard FreeBSD install out in the end. > >Would you mind if I split the "diskless" magic out into >setup_nanobsd_etc() (the parts code you moved in this commit) and then >run it right after install_etc()? It shouldn't make a difference for >normal NanoBSD use, but then I can simply override setup_nanobsd_etc() >in my cutomize script and avoid larger patches against nanobsd.sh. That's ok with me. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49150.1154626450>