Date: Fri, 1 Sep 2017 16:50:36 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Josh Paetzel <jpaetzel@FreeBSD.org> Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf Message-ID: <20170901165036.GA32922@FreeBSD.org> In-Reply-To: <1504283036.3890655.1092421712.7A5915D1@webmail.messagingengine.com> References: <201709011554.v81FssRG083114@repo.freebsd.org> <CAG6CVpVnEejQdE-=SLyLU__PJpuFNmC03FHnnx1Vfnv=uZN20Q@mail.gmail.com> <1504283036.3890655.1092421712.7A5915D1@webmail.messagingengine.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 01, 2017 at 11:23:56AM -0500, Josh Paetzel wrote: > Yeah, the commit message is horrible. I apologize. I'm afraid this is not enough, esp. considering that this issue (utterly bad commit messages) was recently brought up on developers@ once again. Please revert and recommit with proper, elaborate, useful commit log. > The phabricator is a little better but you have to read and parse the > whole thing. > > Then end result of this change is you can kldload ipsec AND tcpmd5, > however ipsec support won't be in GENERIC. Perhaps it should also explain why IPSEC_SUPPORT option is needed, as well (e.g. if it does not cost anything, why not just optimize it away; if it does imply something more, it should be explained and reflected properly in the log). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170901165036.GA32922>