Date: Mon, 26 Jul 2010 11:50:55 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Gabor Kovesdan <gabor@FreeBSD.org> Cc: svn-src-head@freebsd.org, delphij@freebsd.org, svn-src-all@freebsd.org, Doug Barton <dougb@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r210479 - head/usr.bin/grep Message-ID: <86ocduy3k0.fsf@ds4.des.no> In-Reply-To: <4C4CA13C.1090502@FreeBSD.org> (Gabor Kovesdan's message of "Sun, 25 Jul 2010 22:40:28 %2B0200") References: <201007251857.o6PIvmoS031484@svn.freebsd.org> <alpine.BSF.2.00.1007251302550.1706@qbhto.arg> <4C4CA13C.1090502@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gabor Kovesdan <gabor@FreeBSD.org> writes: > I did run regression testing, the test suite that GNU grep has. Does that test suite include a test for the bug you fixed? If not, running it before committing this particular patch was close to useless. By definition, a regression test is designed to trigger a specific bug so the developer(s) can make sure it is not reintroduced at some later point once it's been fixed. Standard procedure is for the developer to write a regression test *before* fixing the bug, and verifying that the test fails when run against the unpatched code and succeeds when run against the patched code. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ocduy3k0.fsf>