Date: Wed, 15 Dec 2004 16:21:14 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Tom Rhodes <trhodes@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/examples/etc make.conf Message-ID: <20041215142114.GA24846@ip.net.ua> In-Reply-To: <20041215090139.53a90960@localhost> References: <200412150210.iBF2AodY094280@repoman.freebsd.org> <20041215084901.GC25967@ip.net.ua> <20041215083548.5455ea2c@localhost> <20041215135230.GA2319@ip.net.ua> <20041215090139.53a90960@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
--u3/rZRmxL6MmkK24 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 15, 2004 at 09:01:39AM -0500, Tom Rhodes wrote: > On Wed, 15 Dec 2004 15:52:30 +0200 > Ruslan Ermilov <ru@FreeBSD.org> wrote: >=20 > > On Wed, Dec 15, 2004 at 08:35:48AM -0500, Tom Rhodes wrote: > > > On Wed, 15 Dec 2004 10:49:01 +0200 > > > Ruslan Ermilov <ru@FreeBSD.org> wrote: > > >=20 > > > > On Wed, Dec 15, 2004 at 02:10:50AM +0000, Tom Rhodes wrote: > > > > > trhodes 2004-12-15 02:10:50 UTC > > > > >=20 > > > > > FreeBSD src repository > > > > >=20 > > > > > Modified files: > > > > > share/examples/etc make.conf=20 > > > > > Log: > > > > > Add a few options with regards to ppp(8) and traceroute. > > > > > Sort the list, please keep this list sorted. > > > > > =20 > > > > > PR: 48569 > > > > > =20 > > > > > Revision Changes Path > > > > > 1.241 +17 -11 src/share/examples/etc/make.conf > > > > >=20 > > > > You unsorted the list, please fix. The correct sorting > > > > order here is in "dictinary order", please see sort(1). > > >=20 > > > Hold on a minute. A good while ago someone (bde? you? other?) > > > told me that these options should be sorted by dictionary order > > > only after the separation of "NOFOO" and "NO_FOO." Am I lost > > > or something? > > >=20 > > You're lost. I fixed this some time ago (in my latest commit > > to this file), and now you disordered it again. ;) >=20 > cvs log make.conf | grep -A 10 'trhodes' > ------------------------------------------- > date: 2003/02/14 20:04:44; author: trhodes; state: Exp; lines: +1 -1 > Move NOMAN down the section without underscore characters. > Add a forgotten `=3D' sign. >=20 > Thanks to: ru, bde > ------------------------------------------ >=20 > Remember that thread? Something about bad sorting of NOMAN > (dictionary format correct but should not be in with the > underscored variables). >=20 In the time of that commit (rev. 1.209), the underscored versions were separated from non-underscored ones. This time (rev. 1.240), they were merged and sorted in dictionary order (for easier human search). You should have preserved the existing style. I don't see any controversy between these two revisions (rev. 1.211 and the upcoming revision when you commit my patch ;), both use the rule "don't break an existing style". Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --u3/rZRmxL6MmkK24 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBwEhaqRfpzJluFF4RAls/AKCVPWnOVVF1B8f7c83LnA0sbVEmtQCffZDq hzjEK0zyQbG4SM6Vhqs+5l8= =MPhb -----END PGP SIGNATURE----- --u3/rZRmxL6MmkK24--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041215142114.GA24846>