Date: Mon, 11 Jul 2011 16:36:18 -0700 From: mdf@FreeBSD.org To: Ali Mashtizadeh <mashtizadeh@gmail.com> Cc: FreeBSD Current <freebsd-current@freebsd.org>, Arnaud Lacombe <lacombar@gmail.com> Subject: Re: Heavy I/O blocks FreeBSD box for several seconds Message-ID: <CAMBSHm9TwOfaY=1TPce-NTukg=oobaqXDx=eAoGJFYWgn4yNuA@mail.gmail.com> In-Reply-To: <CAFL8=th=M2wnszAzfMERJ3NyFGSaHmdrPbTBVn5PKvZ1DHpCJw@mail.gmail.com> References: <4E1421D9.7080808@zedat.fu-berlin.de> <CALH631=F4bSgNDE4w0qcXGMgGxZRRwCP9n-H4M0c%2B1UEaqWr7Q@mail.gmail.com> <4E147F54.40908@zedat.fu-berlin.de> <20110706162811.GA68436@troutmask.apl.washington.edu> <CACqU3MVLr5VXRovs1uV%2BzHazJi2rrjE9Sp3XzsCPJ0Un06pmDQ@mail.gmail.com> <20110706193636.GA69550@troutmask.apl.washington.edu> <4E14CCE5.4050906@zedat.fu-berlin.de> <CAJ-VmomNcbGggbQePi2kBC7uRJm3BenMNKjsqkH5hFLqudsCvg@mail.gmail.com> <20110707015151.GB71966@troutmask.apl.washington.edu> <CAJ-VmongFDGi0amaqod5_NBQcH%2BguA5QMXtttCjTD=ccB==%2BUQ@mail.gmail.com> <CACqU3MVv-YpttXWYnvraR3PT9nh9P1AWMxoXJPevMRhNt4cr5g@mail.gmail.com> <CAJ-VmokC%2BpzoB_x31UGSNt2oRLXfzOK9aXhCMR3FBm7iGEyaAQ@mail.gmail.com> <CACqU3MXVdQfYEBNb9OLnt7CudiBRdvaq3Cd_HXBC8ZrCpmRFvg@mail.gmail.com> <4E1B67C7.8040402@FreeBSD.org> <CACqU3MW==-XAVxAAoUTuU4CWdzc2isFTu6nnUKRTbnvHF7wLow@mail.gmail.com> <CAFL8=th=M2wnszAzfMERJ3NyFGSaHmdrPbTBVn5PKvZ1DHpCJw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 11, 2011 at 4:00 PM, Ali Mashtizadeh <mashtizadeh@gmail.com> wr= ote: > Maybe someone can setup something like reviewboard [1] for developers > to use. This may also help folks who want to keep abreast of the > current work in a particular subsystem or get involved into the > development process more. At my company we use reviews and it seems to > help the catch some bugs and help new engineers ramp up faster. > > [1] http://www.reviewboard.org/ FreeBSD development is completely open; anyone can sign up for the svn-src-* mailing list they are interested in, including svn-src-head@. Code reviews are plenty as well; just check the list archives for discussion of bugs, poor design choices and unintended effects. But most reviews are silent and after-the-fact by looking at the list mail. It's a system that seems to be working just fine for the FreeBSD project so far. This isn't a job for most anyone; it's a volunteer project and so anything that raises the barrier to getting work done for the project should be looked at with skepticism. Is there a specific deficit that you want to address? Thanks, matthew > On Mon, Jul 11, 2011 at 2:48 PM, Arnaud Lacombe <lacombar@gmail.com> wrot= e: >> Hi, >> >> On Mon, Jul 11, 2011 at 5:14 PM, Andriy Gapon <avg@freebsd.org> wrote: >>> on 11/07/2011 23:33 Arnaud Lacombe said the following: >>>> For the record, I would like to see enforced public review for _every_ >>>> patch *before* it is checked in, as a strong rule. gcc system is >>>> particularly interesting. But it is not likely to happen in FreeBSD >>>> where FreeBSD committers are clearly more free than other at >>>> checking-in un-publicly-reviewed stuff (especially _bad_ stuff). >>>> >>>> This would of course apply even to long-time committers, no matter how >>>> it hurt their ego (which I definitively do not care about). >>> >>> Have you just volunteered to review all of the patches that I would lik= e to >>> commit? =A0And are you prepared to take responsibility for quality of y= our reviews? >>> I am sure that other developers will gladly accept your offer too. >>> >> _No-one_ can do all the reviews, especially not me (on a purely >> technical level). ACK must come from subsystem maintainers. Having >> public review would allow the community review, which is now just not >> possible today. As about patches from the maintainer, they might be >> committed without his approval, but still sent for review. If a >> maintainer goes outside his area, he has to get approval from the >> other subsystem maintainer. >> >> =A0- Arnaud >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.or= g" >> > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMBSHm9TwOfaY=1TPce-NTukg=oobaqXDx=eAoGJFYWgn4yNuA>