Date: Wed, 25 Feb 2015 22:45:12 +0000 From: "imp (Warner Losh)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Changed Subscribers] D1967: Attempt to make libcxxrt's dwarf_eh work with strict alignment Message-ID: <a4e789ede0b4e86a5043ce0bcc762122@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-2dch6afcj5u7ayk2c67t-req@FreeBSD.org> References: <differential-rev-PHID-DREV-2dch6afcj5u7ayk2c67t-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
imp added a subscriber: imp. imp added a comment. I'd just do a memcpy version of the read routines. All this #ifdef junk is insane. It will do the right thing every time. INLINE COMMENTS contrib/libcxxrt/dwarf_eh.h:154-163 uint16_t res; memcpy(&res, reinterpret_cast<void *>(*data), sizeof(uint16_)t); would be better. contrib/libcxxrt/dwarf_eh.h:176-188 see above for less insane code. contrib/libcxxrt/dwarf_eh.h:200-221 see above for less insane code. REVISION DETAIL https://reviews.freebsd.org/D1967 To: dim, andrew, bapt, ian, theraven Cc: imp, emaste, freebsd-arm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a4e789ede0b4e86a5043ce0bcc762122>