Date: Sat, 16 Jun 2001 04:26:10 +0100 (BST) From: Mark Valentine <mark@thuvia.demon.co.uk> To: gad@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c Message-ID: <200106160326.f5G3QAH00242@dotar-sojat.thuvia.org> In-Reply-To: Garance A Drosihn's message of Jun 15, 10:43pm
next in thread | raw e-mail | index | archive | help
> From: drosih@rpi.edu (Garance A Drosihn) > Date: Fri 15 Jun, 2001 > Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c > In the middle of writing the commit-log, I remembered that I > wanted to cross-check one more thing. So, I deleted all the > non-CVS (comment) lines in the window, and exited. It seemed > to me that that USED to cause the commit to stop and ask you > if you wanted to abort the commit. CVS doesn't like you deleting the leading blank line it starts you out with. I always thought this was just a dumb comparison of the file before and after editing, and it's annoyed me for years, but I just looked at the code, which tries to be a bit more clever but gets this (common) case wrong. I've submitted simple fixes to bug-cvs and via send-pr to freebsd-bugs: see PR gnu/28189. Cheers, Mark. -- Mark Valentine, Thuvia Labs <mark@thuvia.co.uk> <http://www.thuvia.co.uk>; "Tigers will do ANYTHING for a tuna fish sandwich." Mark Valentine uses "We're kind of stupid that way." *munch* *munch* and endorses FreeBSD -- <http://www.calvinandhobbes.com>; <http://www.freebsd.org>; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200106160326.f5G3QAH00242>