Date: Thu, 10 Oct 2002 08:46:48 -0700 From: Peter Wemm <peter@wemm.org> To: Doug Rabson <dfr@nlsystems.com> Cc: Alfred Perlstein <bright@mu.org>, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ia64/ia32 ia32_misc.c syscalls.master Message-ID: <20021010154648.1670C2A88D@canning.wemm.org> In-Reply-To: <20021010155642.K70762-100000@herring.nlsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Doug Rabson wrote:
> On Wed, 9 Oct 2002, Peter Wemm wrote:
>
> > Alfred Perlstein wrote:
> > > * Alfred Perlstein <bright@mu.org> [021009 15:28] wrote:
> > > > * Peter Wemm <peter@FreeBSD.org> [021009 15:27] wrote:
> > > > > peter 2002/10/09 15:27:24 PDT
> > > > >
> > > > > Modified files:
> > > > > sys/ia64/ia32 ia32_misc.c syscalls.master
> > > > > Log:
> > > > > Try and deal with the #ifdef COMPAT_FREEBSD4 sendfile stuff. This
woul
> > d
> > > > > have been a lot easier if do_sendfile() was usable externally.
> > > >
> > > > I don't object to it being made non-static.
> > >
> > > However using SCARG is depricated according to bde, shouldn't you
> > > just use struct->field?
> >
> > I'm really not all that sure why dfr likes it so much. :-]
>
> I don't like it - I just thought it was "the style". If its deprecated,
> then strip it all out - its ugly.
Yes, it is deprecated. We build the padding directly into the *_args structs
using PADL_(type) and PADR_(type). This happens to work out a lot better
for the syscall argument size calculations too.
Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021010154648.1670C2A88D>